From bd141fec9241e93c1ac8f3f538146108ff33e87e Mon Sep 17 00:00:00 2001 From: Nuno Cruces Date: Mon, 12 Aug 2024 17:50:23 +0100 Subject: [PATCH] Tests. --- driver/driver.go | 2 +- driver/driver_test.go | 12 ++++++++++++ internal/util/error.go | 1 - 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/driver/driver.go b/driver/driver.go index 575b87d..c02ba4b 100644 --- a/driver/driver.go +++ b/driver/driver.go @@ -109,7 +109,7 @@ func init() { func Open(dataSourceName string, fn ...func(*sqlite3.Conn) error) (*sql.DB, error) { var drv SQLite if len(fn) > 2 { - return nil, util.ArgErr + return nil, sqlite3.MISUSE } if len(fn) > 1 { drv.term = fn[1] diff --git a/driver/driver_test.go b/driver/driver_test.go index dba6b76..97b331c 100644 --- a/driver/driver_test.go +++ b/driver/driver_test.go @@ -17,6 +17,18 @@ import ( "github.com/ncruces/go-sqlite3/vfs/memdb" ) +func Test_Open_error(t *testing.T) { + t.Parallel() + + _, err := Open("", nil, nil, nil) + if err == nil { + t.Error("want error") + } + if !errors.Is(err, sqlite3.MISUSE) { + t.Errorf("got %v, want sqlite3.MISUSE", err) + } +} + func Test_Open_dir(t *testing.T) { t.Parallel() diff --git a/internal/util/error.go b/internal/util/error.go index 8ac52c5..2aecac9 100644 --- a/internal/util/error.go +++ b/internal/util/error.go @@ -12,7 +12,6 @@ func (e ErrorString) Error() string { return string(e) } const ( NilErr = ErrorString("sqlite3: invalid memory address or null pointer dereference") OOMErr = ErrorString("sqlite3: out of memory") - ArgErr = ErrorString("sqlite3: invalid argument") RangeErr = ErrorString("sqlite3: index out of range") NoNulErr = ErrorString("sqlite3: missing NUL terminator") NoBinaryErr = ErrorString("sqlite3: no SQLite binary embed/set/loaded")