js/shoelace
1
0
Fork 0
mirror of https://github.com/shoelace-style/shoelace.git synced 2026-01-12 02:59:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

improve range/tooltip perf; fixes #2064

Browse Source
This commit is contained in:
Cory LaViska
2024-10-28 13:38:51 -04:00
parent aca0f3d64a
commit 0242fc66ad
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
docs/pages/resources/changelog.md
View File

@@ -17,6 +17,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti
- Added support for <kbd>Enter</kbd> to `<sl-split-panel>` to align with ARIA APG's [window splitter pattern](https://www.w3.org/WAI/ARIA/apg/patterns/windowsplitter/) [#2234] - Added support for <kbd>Enter</kbd> to `<sl-split-panel>` to align with ARIA APG's [window splitter pattern](https://www.w3.org/WAI/ARIA/apg/patterns/windowsplitter/) [#2234]
- Fixed a bug in `<sl-carousel>` that caused the navigation icons to be reversed - Fixed a bug in `<sl-carousel>` that caused the navigation icons to be reversed
- Fixed a bug in `<sl-select>` that prevented label changes in `<sl-option>` from updating the controller [#1971] - Fixed a bug in `<sl-select>` that prevented label changes in `<sl-option>` from updating the controller [#1971]
- Improved performance of `<sl-range>` by skipping positioning logic when tooltip isn't shown [#2064]
## 2.18.0 ## 2.18.0

2
src/components/range/range.component.ts
View File

@@ -215,7 +215,7 @@ export default class SlRange extends ShoelaceElement implements ShoelaceFormCont
this.syncProgress(percent); this.syncProgress(percent);
if (this.tooltip !== 'none') { if (this.tooltip !== 'none' && this.hasTooltip) {
// Ensure updates are drawn before we sync the tooltip // Ensure updates are drawn before we sync the tooltip
this.updateComplete.then(() => this.syncTooltip(percent)); this.updateComplete.then(() => this.syncTooltip(percent));
} }