From 7edd99bf3135b7e450db273dc053f9cef6210af5 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Wed, 13 Jan 2021 18:01:36 -0500 Subject: [PATCH] Remove text from badge types --- docs/getting-started/changelog.md | 1 + src/components/badge/badge.tsx | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/getting-started/changelog.md b/docs/getting-started/changelog.md index 648fd2b9..d029d1f3 100644 --- a/docs/getting-started/changelog.md +++ b/docs/getting-started/changelog.md @@ -21,6 +21,7 @@ _During the beta period, these restrictions may be relaxed in the event of a mis - Fixed a bug in `sl-color-picker` where the toggle button was smaller than the preview button in Safari - Fixed a bug in `sl-tab-group` where activating a nested tab group didn't work properly [#299](https://github.com/shoelace-style/shoelace/issues/299) - Fixed a bug in `sl-alert`, `sl-dialog`, `sl-drawer`, `sl-select`, and `sl-tag` where the close button's base wasn't exported so it couldn't be styled +- Removed `text` type from `sl-badge` as it was erroneously copied and never had styles - Updated `sl-tab-group` so the `active` prop is reflected to the attribute - Updated the docs to show dependencies instead of dependents which is much more useful when working with the custom elements bundle - Updated to Bootstrap Icons 1.3.0 diff --git a/src/components/badge/badge.tsx b/src/components/badge/badge.tsx index e9692225..ef1f310d 100644 --- a/src/components/badge/badge.tsx +++ b/src/components/badge/badge.tsx @@ -18,7 +18,7 @@ export class Badge { badge: HTMLElement; /** The badge's type. */ - @Prop() type: 'primary' | 'success' | 'info' | 'warning' | 'danger' | 'text' = 'primary'; + @Prop() type: 'primary' | 'success' | 'info' | 'warning' | 'danger' = 'primary'; /** Set to true to draw a pill-style badge with rounded edges. */ @Prop() pill = false; @@ -40,7 +40,6 @@ export class Badge { 'badge--info': this.type === 'info', 'badge--warning': this.type === 'warning', 'badge--danger': this.type === 'danger', - 'badge--text': this.type === 'text', 'badge--pill': this.pill, 'badge--pulse': this.pulse }}