From 597a06c97c4ce7746ccd3b862d7270d1543cb7de Mon Sep 17 00:00:00 2001 From: Alessandro Date: Wed, 25 Oct 2023 19:04:31 +0200 Subject: [PATCH 1/3] fix(carousel): add instance check to isCarouselItem (#1684) --- src/components/carousel/carousel.component.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/carousel/carousel.component.ts b/src/components/carousel/carousel.component.ts index c5ae7810..5c200305 100644 --- a/src/components/carousel/carousel.component.ts +++ b/src/components/carousel/carousel.component.ts @@ -235,8 +235,8 @@ export default class SlCarousel extends ShoelaceElement { } } - private isCarouselItem(node: HTMLElement): node is SlCarouselItem { - return node.tagName.toLowerCase() === 'sl-carousel-item'; + private isCarouselItem(node: Node): node is SlCarouselItem { + return node instanceof Element && node.tagName.toLowerCase() === 'sl-carousel-item'; } private handleSlotChange = (mutations: MutationRecord[]) => { From b7a4a228d62793f5bd3123570a1b88367a6dd6ab Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Wed, 25 Oct 2023 13:08:51 -0400 Subject: [PATCH 2/3] update changelog --- docs/pages/resources/changelog.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/pages/resources/changelog.md b/docs/pages/resources/changelog.md index 052f111a..a92ea1a0 100644 --- a/docs/pages/resources/changelog.md +++ b/docs/pages/resources/changelog.md @@ -12,6 +12,10 @@ Components with the Experimental bad New versions of Shoelace are released as-needed and generally occur when a critical mass of changes have accumulated. At any time, you can see what's coming in the next release by visiting [next.shoelace.style](https://next.shoelace.style). +## 2.11.2 + +- Fixed a bug in `` component that caused an error to be thrown when rendered with Lit [#1684] + ## 2.11.1 - Improved the experimental `` component [#1605] From b9fa2a60fe2cb48a6894e96c121515679a44edd9 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Wed, 25 Oct 2023 13:09:11 -0400 Subject: [PATCH 3/3] 2.11.2 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 4d9ba9bb..51761bc2 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@shoelace-style/shoelace", - "version": "2.11.1", + "version": "2.11.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@shoelace-style/shoelace", - "version": "2.11.1", + "version": "2.11.2", "license": "MIT", "dependencies": { "@ctrl/tinycolor": "^4.0.2", diff --git a/package.json b/package.json index 0fa2eda1..155fb6f8 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "@shoelace-style/shoelace", "description": "A forward-thinking library of web components.", - "version": "2.11.1", + "version": "2.11.2", "homepage": "https://github.com/shoelace-style/shoelace", "author": "Cory LaViska", "license": "MIT",