From 91193e2d60c354bf80cbce940c065caa5a51651b Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Mon, 23 Sep 2024 13:37:32 -0400 Subject: [PATCH] fixes #2179 (#2181) --- docs/pages/resources/changelog.md | 1 + src/components/popup/popup.component.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/pages/resources/changelog.md b/docs/pages/resources/changelog.md index 7887b679..15766a05 100644 --- a/docs/pages/resources/changelog.md +++ b/docs/pages/resources/changelog.md @@ -14,6 +14,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti ## Next +- Improved performance of `` by waiting for the active state before spinning up the positioning library [#2179] - Fixed a bug in `` that made the suffix slot collide with the clear button [#2145] ## 2.17.0 diff --git a/src/components/popup/popup.component.ts b/src/components/popup/popup.component.ts index 7fabb4f2..abeda890 100644 --- a/src/components/popup/popup.component.ts +++ b/src/components/popup/popup.component.ts @@ -264,7 +264,7 @@ export default class SlPopup extends ShoelaceElement { } // If the anchor is valid, start it up - if (this.anchorEl) { + if (this.anchorEl && this.active) { this.start(); } }