From b07238d536648cbbda7d68599fc2a8cf1a24270b Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Tue, 20 Dec 2022 13:37:30 -0500 Subject: [PATCH] temporarily disable a11y bug --- src/components/menu-item/menu-item.test.ts | 13 +++++-------- src/components/menu-item/menu-item.ts | 5 ++++- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/components/menu-item/menu-item.test.ts b/src/components/menu-item/menu-item.test.ts index 588ae1a4..f2c165af 100644 --- a/src/components/menu-item/menu-item.test.ts +++ b/src/components/menu-item/menu-item.test.ts @@ -5,9 +5,11 @@ import type SlMenuItem from './menu-item'; describe('', () => { it('passes accessibility test', async () => { const el = await fixture(html` - - Test - + + Item 1 + Item 2 + Item 3 + `); await expect(el).to.be.accessible(); }); @@ -15,8 +17,6 @@ describe('', () => { it('default properties', async () => { const el = await fixture(html` Test `); - expect(el.checked).to.be.false; - expect(el.getAttribute('aria-checked')).to.equal('false'); expect(el.value).to.equal(''); expect(el.disabled).to.be.false; expect(el.getAttribute('aria-disabled')).to.equal('false'); @@ -25,9 +25,6 @@ describe('', () => { it('changes aria attributes', async () => { const el = await fixture(html` Test `); - el.checked = true; - await aTimeout(100); - expect(el.getAttribute('aria-checked')).to.equal('true'); el.disabled = true; await aTimeout(100); expect(el.getAttribute('aria-disabled')).to.equal('true'); diff --git a/src/components/menu-item/menu-item.ts b/src/components/menu-item/menu-item.ts index 20fa17f1..d276e576 100644 --- a/src/components/menu-item/menu-item.ts +++ b/src/components/menu-item/menu-item.ts @@ -58,7 +58,10 @@ export default class SlMenuItem extends ShoelaceElement { @watch('checked') handleCheckedChange() { - this.setAttribute('aria-checked', this.checked ? 'true' : 'false'); + // + // TODO - fix a11y bug + // + // this.setAttribute('aria-checked', this.checked ? 'true' : 'false'); } @watch('disabled')