From b6c9b64ec0fed14cf04e66c5cb2f4ddac5693583 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Mon, 20 Nov 2023 19:59:39 -0500 Subject: [PATCH] restore ff tests --- src/components/color-picker/color-picker.test.ts | 6 ++---- src/components/dialog/dialog.test.ts | 3 +-- src/components/select/select.test.ts | 3 +-- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/components/color-picker/color-picker.test.ts b/src/components/color-picker/color-picker.test.ts index 335ded7c..0c41517b 100644 --- a/src/components/color-picker/color-picker.test.ts +++ b/src/components/color-picker/color-picker.test.ts @@ -385,8 +385,7 @@ describe('', () => { expect(blurHandler).to.have.been.calledOnce; }); - // NOTE: Firefox is failing locally for me even though manual tests show this is working fine - it.skip('should emit sl-focus when rendered inline and focused', async () => { + it('should emit sl-focus when rendered inline and focused', async () => { const el = await fixture(html`
@@ -410,8 +409,7 @@ describe('', () => { expect(blurHandler).to.have.been.calledOnce; }); - // NOTE: Firefox is failing locally for me even though manual tests show this is working fine - it.skip('should focus and blur when calling focus() and blur() and rendered as a dropdown', async () => { + it('should focus and blur when calling focus() and blur() and rendered as a dropdown', async () => { const colorPicker = await fixture(html` `); const focusHandler = sinon.spy(); const blurHandler = sinon.spy(); diff --git a/src/components/dialog/dialog.test.ts b/src/components/dialog/dialog.test.ts index 963f37ec..d0817075 100644 --- a/src/components/dialog/dialog.test.ts +++ b/src/components/dialog/dialog.test.ts @@ -149,8 +149,7 @@ describe('', () => { }); // https://github.com/shoelace-style/shoelace/issues/1382 - // NOTE: Firefox is failing locally for me even though manual tests show this is working fine - it.skip('should properly cycle through tabbable elements when sl-dialog is used in a shadowRoot', async () => { + it('should properly cycle through tabbable elements when sl-dialog is used in a shadowRoot', async () => { class AContainer extends LitElement { get dialog() { return this.shadowRoot?.querySelector('sl-dialog'); diff --git a/src/components/select/select.test.ts b/src/components/select/select.test.ts index 23feed7c..acd4ea35 100644 --- a/src/components/select/select.test.ts +++ b/src/components/select/select.test.ts @@ -443,8 +443,7 @@ describe('', () => { }); describe('when resetting a form', () => { - // NOTE: Firefox is failing locally for me even though manual tests show this is working fine - it.skip('should reset the element to its initial value', async () => { + it('should reset the element to its initial value', async () => { const form = await fixture(html`