optional chain disconnects; fixes #2127 (#2129)

This commit is contained in:
Cory LaViska
2024-08-05 08:46:30 -04:00
committed by GitHub
parent d0441f53ce
commit bc6d25acbc
8 changed files with 12 additions and 9 deletions

View File

@@ -103,7 +103,7 @@ export default class SlCarousel extends ShoelaceElement {
disconnectedCallback(): void {
super.disconnectedCallback();
this.mutationObserver.disconnect();
this.mutationObserver?.disconnect();
}
protected firstUpdated(): void {

View File

@@ -89,7 +89,7 @@ export default class SlDetails extends ShoelaceElement {
disconnectedCallback() {
super.disconnectedCallback();
this.detailsObserver.disconnect();
this.detailsObserver?.disconnect();
}
private handleSummaryClick(event: MouseEvent) {

View File

@@ -132,7 +132,7 @@ export default class SlRange extends ShoelaceElement implements ShoelaceFormCont
disconnectedCallback() {
super.disconnectedCallback();
this.resizeObserver.unobserve(this.input);
this.resizeObserver?.unobserve(this.input);
}
private handleChange() {

View File

@@ -85,7 +85,7 @@ export default class SlSplitPanel extends ShoelaceElement {
disconnectedCallback() {
super.disconnectedCallback();
this.resizeObserver.unobserve(this);
this.resizeObserver?.unobserve(this);
}
private detectSize() {

View File

@@ -120,8 +120,8 @@ export default class SlTabGroup extends ShoelaceElement {
disconnectedCallback() {
super.disconnectedCallback();
this.mutationObserver.disconnect();
this.resizeObserver.unobserve(this.nav);
this.mutationObserver?.disconnect();
this.resizeObserver?.unobserve(this.nav);
}
private getAllTabs() {

View File

@@ -164,7 +164,7 @@ export default class SlTextarea extends ShoelaceElement implements ShoelaceFormC
disconnectedCallback() {
super.disconnectedCallback();
if (this.input) {
this.resizeObserver.unobserve(this.input);
this.resizeObserver?.unobserve(this.input);
}
}

View File

@@ -111,8 +111,7 @@ export default class SlTree extends ShoelaceElement {
disconnectedCallback() {
super.disconnectedCallback();
this.mutationObserver.disconnect();
this.mutationObserver?.disconnect();
}
// Generates a clone of the expand icon element to use for each tree item