From cc7501e530a98ea92b5dc9f1a08d5ba4e32c9c64 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Wed, 12 Aug 2020 08:21:39 -0400 Subject: [PATCH] Allow type to select to accept symbols --- CHANGELOG.md | 1 + src/components/menu/menu.tsx | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7acd6974..40348077 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ - Fixed a bug where button groups with tooltips experienced an odd spacing issue in Safari - Fixed a bug where scrolling in dropdowns/selects didn't work properly on Windows (special thanks to [Trendy](http://github.com/trendy) for helping troubleshoot!) - Fixed a bug where selecting a menu item in a dropdown would cause Safari to scroll +- Fixed a bug where type to select wouldn't accept symbols - Moved scrolling logic from `sl-menu` to `sl-dropdown` ## 2.0.0-beta.12 diff --git a/src/components/menu/menu.tsx b/src/components/menu/menu.tsx index 371cfe27..b98bc6b4 100644 --- a/src/components/menu/menu.tsx +++ b/src/components/menu/menu.tsx @@ -168,10 +168,7 @@ export class Menu { } } - // Handle type-to-select behavior when non-control characters are entered - if (event.key === ' ' || /^[\d\w]$/i.test(event.key)) { - this.typeToSelect(event.key); - } + this.typeToSelect(event.key); } handleMouseDown(event: MouseEvent) {