From fb899ad676575d00d56b4cc9d96ca41be8be6aef Mon Sep 17 00:00:00 2001 From: ErikOnBike Date: Wed, 24 May 2023 16:34:42 +0200 Subject: [PATCH] Replace .map with .forEach when return value not used. See issue #740 (#1349) --- src/components/tab-group/tab-group.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/tab-group/tab-group.ts b/src/components/tab-group/tab-group.ts index 9bf1e475..5d3b98aa 100644 --- a/src/components/tab-group/tab-group.ts +++ b/src/components/tab-group/tab-group.ts @@ -250,8 +250,8 @@ export default class SlTabGroup extends ShoelaceElement { this.activeTab = tab; // Sync active tab and panel - this.tabs.map(el => (el.active = el === this.activeTab)); - this.panels.map(el => (el.active = el.name === this.activeTab?.panel)); + this.tabs.forEach(el => (el.active = el === this.activeTab)); + this.panels.forEach(el => (el.active = el.name === this.activeTab?.panel)); this.syncIndicator(); if (['top', 'bottom'].includes(this.placement)) {