js/webawesome
1
0
Fork 0
mirror of https://github.com/shoelace-style/webawesome.git synced 2026-01-12 04:09:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix SVG fill in <wa-icon> (#1784)

Browse Source 
* fix svg fill; closes #1733

* remove fill
This commit is contained in:
Cory LaViska
2025-11-19 07:33:56 -05:00
committed by GitHub
parent 9706964511
commit 1429095eed
3 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/webawesome/docs/docs/resources/changelog.md
View File

@@ -15,6 +15,7 @@ Components with the <wa-badge variant="warning">Experimental</wa-badge> badge sh
- Fixed a bug in `<wa-slider>` that caused some touch devices to end up with the incorrect value [issue:1703] - Fixed a bug in `<wa-slider>` that caused some touch devices to end up with the incorrect value [issue:1703]
- Fixed a bug in `<wa-card>` that prevented some slots from being detected correctly [discuss:1450] - Fixed a bug in `<wa-card>` that prevented some slots from being detected correctly [discuss:1450]
- Fixed a bug in `<wa-icon>` that caused some icon libraries to render with the incorrect SVG fill [issue:1733]
- Fixed a bug in `<wa-tree-item>` that caused the spinner to not show when lazy loading [issue:1678] - Fixed a bug in `<wa-tree-item>` that caused the spinner to not show when lazy loading [issue:1678]
- Fixed a bug in `<wa-dropdown>` that caused the browser to hang when cancelling the `wa-hide` event [issue:1483] - Fixed a bug in `<wa-dropdown>` that caused the browser to hang when cancelling the `wa-hide` event [issue:1483]
- Improved performance of `<wa-icon>` so initial rendering occurs faster, especially with multiple icons on the page [issue:1729] - Improved performance of `<wa-icon>` so initial rendering occurs faster, especially with multiple icons on the page [issue:1729]

1
packages/webawesome/src/components/icon/icon.css
View File

@@ -25,7 +25,6 @@
svg { svg {
height: 1em; height: 1em;
fill: currentColor;
overflow: visible; overflow: visible;
/* Duotone colors with path-specific opacity fallback */ /* Duotone colors with path-specific opacity fallback */

2
packages/webawesome/src/components/icon/icon.ts
View File

@@ -249,7 +249,7 @@ export default class WaIcon extends WebAwesomeElement {
return this.svg; return this.svg;
} }
return html`<svg part="svg" fill="currentColor" width="16" height="16"></svg>`; return html`<svg part="svg" width="16" height="16"></svg>`;
} }
} }