From a8774b5c88a6d51c9a382147b6b4525bdd1f44fa Mon Sep 17 00:00:00 2001 From: Lea Verou Date: Mon, 9 Dec 2024 17:15:07 -0500 Subject: [PATCH 1/2] [code-demo] Fix Safari collapsing bug --- src/components/code-demo/code-demo.styles.ts | 48 +++++++++----------- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/src/components/code-demo/code-demo.styles.ts b/src/components/code-demo/code-demo.styles.ts index b9f3d48a2..4992791f8 100644 --- a/src/components/code-demo/code-demo.styles.ts +++ b/src/components/code-demo/code-demo.styles.ts @@ -66,6 +66,7 @@ export default css` overflow: hidden; transition-property: height, display; transition-behavior: allow-discrete; + display: block; &::slotted(pre) { position: relative; @@ -82,49 +83,44 @@ export default css` &:not(:has(+ #buttons)) { border-bottom: none; } - } - [part~='toggle-button'] wa-icon { - transition-property: rotate; - } - - :host(:not([open])) { - #source, - [part~='toggle-button'] wa-icon { - transition-duration: var(--code-collapse-duration); - } - - #source { - /* Collapsed */ + /* Collapsed */ + &:not(:host([open]) *) { height: 0px; display: none; } - } - :host([open]) { - #source, - [part~='toggle-button'] wa-icon { - transition-duration: var(--code-expand-duration); - } - - #source { - /* Expanded */ + /* Expanded */ + &:is(:host([open]) *) { height: auto; display: block; - } - @starting-style { - #source { + @starting-style { height: 0px; display: block; } } + } - [part~='toggle-button'] wa-icon { + [part~='toggle-button'] wa-icon { + transition-property: rotate; + + &:is(:host([open]) *) { rotate: 180deg; } } + #source, + [part~='toggle-button'] wa-icon { + &:not(:host([open]) *) { + transition-duration: var(--code-collapse-duration); + } + + &:is(:host([open]) *) { + transition-duration: var(--code-expand-duration); + } + } + #buttons { display: flex; align-items: stretch; From 4526effbfa9aeff8befac0b98f7e912314bacae7 Mon Sep 17 00:00:00 2001 From: Konnor Rogers Date: Mon, 9 Dec 2024 17:30:56 -0500 Subject: [PATCH 2/2] fix footer / header dialog (#285) --- docs/_includes/sidebar.njk | 3 ++- docs/docs/patterns/portfilio.md | 9 --------- src/components/page/page.ts | 2 ++ 3 files changed, 4 insertions(+), 10 deletions(-) delete mode 100644 docs/docs/patterns/portfilio.md diff --git a/docs/_includes/sidebar.njk b/docs/_includes/sidebar.njk index 058ecf734..5f8ba90c0 100644 --- a/docs/_includes/sidebar.njk +++ b/docs/_includes/sidebar.njk @@ -262,7 +262,8 @@
  • Category Previews
  • Shopping Carts
  • Category Filters
  • -
  • Product Detail
  • mary">Order Summaries +
  • Product Detail
  • +
  • Order Summaries
  • Order History
  • diff --git a/docs/docs/patterns/portfilio.md b/docs/docs/patterns/portfilio.md deleted file mode 100644 index 99f893c27..000000000 --- a/docs/docs/patterns/portfilio.md +++ /dev/null @@ -1,9 +0,0 @@ ---- -title: Business -description: TODO -layout: pattern.njk ---- - -TODO Page Description - -## Examples \ No newline at end of file diff --git a/src/components/page/page.ts b/src/components/page/page.ts index 191b98d4d..9fcb90035 100644 --- a/src/components/page/page.ts +++ b/src/components/page/page.ts @@ -298,6 +298,8 @@ export default class WaPage extends WebAwesomeElement { footer:drawer__footer " class="navigation-drawer" + with-header + with-footer >