From 310f7a8c5d1b8616eb0f2f136c077b7d11fa2d44 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Tue, 22 Jul 2025 13:57:07 -0400 Subject: [PATCH] fix dialog and drawer header; fixes #1209 (#1213) --- packages/webawesome/docs/docs/resources/changelog.md | 4 ++++ packages/webawesome/src/components/dialog/dialog.ts | 4 +--- packages/webawesome/src/components/drawer/drawer.ts | 4 +--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/webawesome/docs/docs/resources/changelog.md b/packages/webawesome/docs/docs/resources/changelog.md index 7945b4bce..829d27e42 100644 --- a/packages/webawesome/docs/docs/resources/changelog.md +++ b/packages/webawesome/docs/docs/resources/changelog.md @@ -14,6 +14,10 @@ Components with the Experimental badge sh - Added the `icon-position` attribute to `` [discuss:1099] +### Bug Fixes and Improvements {data-no-outline} + +- Fixed a bug in `` and `` that prevented the header from showing when the label was missing [issue:1209] + ## 3.0.0-beta.3 ### New Features {data-no-outline} diff --git a/packages/webawesome/src/components/dialog/dialog.ts b/packages/webawesome/src/components/dialog/dialog.ts index 0167718af..48cd8d37a 100644 --- a/packages/webawesome/src/components/dialog/dialog.ts +++ b/packages/webawesome/src/components/dialog/dialog.ts @@ -205,9 +205,7 @@ export default class WaDialog extends WebAwesomeElement { } render() { - const hasHeader = - !this.withoutHeader && - (this.label.length > 0 || this.hasSlotController.test('label') || this.hasSlotController.test('header-actions')); + const hasHeader = !this.withoutHeader; const hasFooter = this.hasSlotController.test('footer'); return html` diff --git a/packages/webawesome/src/components/drawer/drawer.ts b/packages/webawesome/src/components/drawer/drawer.ts index e1c35e52c..cd7d643cb 100644 --- a/packages/webawesome/src/components/drawer/drawer.ts +++ b/packages/webawesome/src/components/drawer/drawer.ts @@ -218,9 +218,7 @@ export default class WaDrawer extends WebAwesomeElement { } render() { - const hasHeader = - !this.withoutHeader && - (this.label.length > 0 || this.hasSlotController.test('label') || this.hasSlotController.test('header-actions')); + const hasHeader = !this.withoutHeader; const hasFooter = this.hasSlotController.test('footer'); return html`