From 3b3cb6d61df3478873683ec59968f34cf7dacfb8 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Wed, 29 Jun 2022 08:09:25 -0400 Subject: [PATCH] fixes #786 --- docs/resources/changelog.md | 5 +++++ src/components/checkbox/checkbox.ts | 34 +++++++++++++---------------- src/components/radio/radio.ts | 14 +++++------- 3 files changed, 26 insertions(+), 27 deletions(-) diff --git a/docs/resources/changelog.md b/docs/resources/changelog.md index 5bc05972c..f0ec0d8bc 100644 --- a/docs/resources/changelog.md +++ b/docs/resources/changelog.md @@ -6,6 +6,11 @@ Components with the Experimental bad _During the beta period, these restrictions may be relaxed in the event of a mission-critical bug._ 🐛 +## Next + +- Moved the `checked-icon` and `indeterminate-icon` parts from a wrapper `` to the `` in `` [#786](https://github.com/shoelace-style/shoelace/issues/786) +- Moved the `checked-icon` part from a wrapper `` to the `` in `` [#786](https://github.com/shoelace-style/shoelace/issues/786) + ## 2.0.0-beta.77 - Added styles to required form controls so they show an asterisk next to the label by default diff --git a/src/components/checkbox/checkbox.ts b/src/components/checkbox/checkbox.ts index e37d9b3da..58a47c6c2 100644 --- a/src/components/checkbox/checkbox.ts +++ b/src/components/checkbox/checkbox.ts @@ -154,33 +154,29 @@ export default class SlCheckbox extends LitElement { ${this.checked ? html` - - - - - - - - + + + + + + - - + + ` : ''} ${!this.checked && this.indeterminate ? html` - - - - - - - + + + + + - - + + ` : ''} diff --git a/src/components/radio/radio.ts b/src/components/radio/radio.ts index b0fbe0053..6f6e1d75c 100644 --- a/src/components/radio/radio.ts +++ b/src/components/radio/radio.ts @@ -179,15 +179,13 @@ export default class SlRadio extends LitElement { @focus=${this.handleFocus} /> - - - - - - + + + + - - + +