From 4621094ea1e567a633b6be89bdc5d748d6cb1ed5 Mon Sep 17 00:00:00 2001 From: Lea Verou Date: Fri, 14 Feb 2025 12:40:09 -0500 Subject: [PATCH] [Tab] Avoid sprouting attributes in the constructor --- src/components/tab/tab.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/components/tab/tab.ts b/src/components/tab/tab.ts index 202b9a86f..5abbc134c 100644 --- a/src/components/tab/tab.ts +++ b/src/components/tab/tab.ts @@ -24,7 +24,6 @@ let id = 0; @customElement('wa-tab') export default class WaTab extends WebAwesomeElement { static shadowStyle = styles; - public slot = 'nav'; // Auto-slot into nav slot private readonly attrId = ++id; private readonly componentId = `wa-tab-${this.attrId}`; @@ -47,6 +46,9 @@ export default class WaTab extends WebAwesomeElement { @property({ type: Number, reflect: true }) tabIndex = 0; connectedCallback() { + // Auto-slot into nav slot + this.slot ||= 'nav'; + super.connectedCallback(); this.setAttribute('role', 'tab'); }