From 5016d27af71e5706c7548c536ff55b561b0787b7 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Tue, 18 Jul 2023 13:11:08 -0400 Subject: [PATCH] remove test because we can't reliably suppress retargeted clicks --- docs/pages/components/button.md | 2 +- src/components/button/button.test.ts | 21 --------------------- 2 files changed, 1 insertion(+), 22 deletions(-) diff --git a/docs/pages/components/button.md b/docs/pages/components/button.md index de436642b..79494b3b9 100644 --- a/docs/pages/components/button.md +++ b/docs/pages/components/button.md @@ -455,7 +455,7 @@ const App = () => ( ### Disabled -Use the `disabled` attribute to disable a button. Clicks will be suppressed until the disabled state is removed. +Use the `disabled` attribute to disable a button. ```html:preview Default diff --git a/src/components/button/button.test.ts b/src/components/button/button.test.ts index 1f1fe8c1c..c99faf591 100644 --- a/src/components/button/button.test.ts +++ b/src/components/button/button.test.ts @@ -68,27 +68,6 @@ describe('', () => { const el = await fixture(html` Button Label `); expect(el.shadowRoot!.querySelector('a[disabled]')).not.to.exist; }); - - it('should not bubble up clicks', async () => { - const button = await fixture(html` Button Label `); - const handleClick = sinon.spy(); - button.addEventListener('click', handleClick); - button.click(); - - expect(handleClick).not.to.have.been.called; - - button.shadowRoot!.querySelector('button')!.click(); - expect(handleClick).not.to.have.been.called; - - const buttonLink = await fixture(html` Button Label `); - buttonLink.addEventListener('click', handleClick); - buttonLink.click(); - - expect(handleClick).not.to.have.been.called; - - buttonLink.shadowRoot!.querySelector('a')!.click(); - expect(handleClick).not.to.have.been.called; - }); }); it('should have title if title attribute is set', async () => {