js/webawesome
1
0
Fork 0
mirror of https://github.com/shoelace-style/webawesome.git synced 2026-01-12 12:09:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix switch's submitted value; fixes #409 (#442)

Browse Source 
* fix switch's submitted value; fixes #409

* update tests
This commit is contained in:
Cory LaViska
2025-01-07 17:01:27 -05:00
committed by GitHub
parent e046015ed5
commit 559efcd1d2
3 changed files with 5 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/components/switch/switch.test.ts
View File

@@ -20,8 +20,7 @@ describe('<wa-switch>', () => {
const el = await fixture<WaSwitch>(html` <wa-switch></wa-switch> `);
expect(el.name).to.equal(null);
// TODO - fix default value
// expect(el.value).to.be.null;
expect(el.value).to.equal('on');
expect(el.title).to.equal('');
expect(el.disabled).to.be.false;
expect(el.required).to.be.false;
@@ -138,10 +137,7 @@ describe('<wa-switch>', () => {
});
describe('when submitting a form', () => {
//
// TODO - this test should pass, so this is likely a bug in the component
//
it.skip('should submit the correct value when a value is provided', async () => {
it('should submit the correct value when a value is provided', async () => {
const form = await fixture<HTMLFormElement>(html`
<form>
<wa-switch name="a" value="1" checked></wa-switch>
@@ -215,10 +211,7 @@ describe('<wa-switch>', () => {
expect(waSwitch.checkValidity()).to.be.true;
});
//
// TODO - this test should pass, so this is likely a bug in the component
//
it.skip('should be present in form data when using the form attribute and located outside of a <form>', async () => {
it('should be present in form data when using the form attribute and located outside of a <form>', async () => {
const el = await fixture<HTMLFormElement>(html`
<div>
<form id="f">

7
src/components/switch/switch.ts
View File

@@ -212,16 +212,11 @@ export default class WaSwitch extends WebAwesomeFormAssociatedElement {
setValue(value: string | File | FormData | null, stateValue?: string | File | FormData | null | undefined): void {
if (!this.checked) {
this.value = null;
this.internals.setFormValue(null, null);
return;
}
if (!value) {
value = 'on';
}
this.internals.setFormValue(value, stateValue);
this.internals.setFormValue(value ?? 'on', stateValue);
}
formResetCallback(): void {