From 635936770678ca5202d77d4ac9e159f30b43cb14 Mon Sep 17 00:00:00 2001
From: Cory LaViska <cory@abeautifulsite.net>
Date: Thu, 13 Apr 2023 12:52:03 -0400
Subject: [PATCH] no roles on slots; fixes #1287

---
 docs/resources/changelog.md       | 1 +
 src/components/details/details.ts | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/docs/resources/changelog.md b/docs/resources/changelog.md
index 659ef3a13..a6c507106 100644
--- a/docs/resources/changelog.md
+++ b/docs/resources/changelog.md
@@ -22,6 +22,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti
 - Improved the behavior of `<sl-carousel>` when used inside a flex container [#1235](https://github.com/shoelace-style/shoelace/pull/1235)
 - Improved the behavior of `<sl-tree-item>` to support buttons and other interactive elements [#1234](https://github.com/shoelace-style/shoelace/issues/1234)
 - Improved the performance of `<sl-include>` to prevent an apparent memory leak in some browsers [#1284](https://github.com/shoelace-style/shoelace/pull/1284)
+- Improved the accessibility of `<sl-select>`, `<sl-split-panel>`, and `<sl-details>` by ensuring slots don't have roles [#1287](https://github.com/shoelace-style/shoelace/issues/1287)
 
 ## 2.3.0
 
diff --git a/src/components/details/details.ts b/src/components/details/details.ts
index 6c9f9094c..908d0bfeb 100644
--- a/src/components/details/details.ts
+++ b/src/components/details/details.ts
@@ -194,8 +194,8 @@ export default class SlDetails extends ShoelaceElement {
           </span>
         </div>
 
-        <div class="details__body">
-          <slot part="content" id="content" class="details__content" role="region" aria-labelledby="header"></slot>
+        <div class="details__body" role="region" aria-labelledby="header">
+          <slot part="content" id="content" class="details__content"></slot>
         </div>
       </div>
     `;