js/webawesome
1
0
Fork 0
mirror of https://github.com/shoelace-style/webawesome.git synced 2026-01-12 04:09:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Slot aria attributes (#1296)

Browse Source 
* Fix acessability issue

* Additionally adapted the test

* Added more accessability tests

* Updated the testing documentation

to take the fact that accessability checks cover only
rendered content into account

---------

Co-authored-by: Dominikus Hellgartner <dominikus.hellgartner@gmail.com>
This commit is contained in:
dhellgartner
2023-04-13 18:45:52 +02:00
committed by GitHub
parent 0f02fffc3a
commit 65734dc993
6 changed files with 55 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/resources/contributing.md
View File

@@ -369,7 +369,7 @@ This will render the icons instantly whereas the default library will fetch them
What to test for a given component:
- Start with a simple test that checks that the default version of the component still renders.
- Add at least one accessibility test:
- Add at least one accessibility test (The accessability check only covers the parts of the DOM which are currently visible and rendered. Depending on the component, more than one accessability test is required to cover all scenarios.):
```ts
const myComponent = await fixture<SlAlert>(html`<sl-my-component>SomeContent</sl-my-component>`);