diff --git a/.github/workflows/client_tests.js.yml b/.github/workflows/client_tests.yml similarity index 85% rename from .github/workflows/client_tests.js.yml rename to .github/workflows/client_tests.yml index 57c0d24fe..7d44e099d 100644 --- a/.github/workflows/client_tests.js.yml +++ b/.github/workflows/client_tests.yml @@ -9,10 +9,6 @@ on: pull_request: branches: [next] -defaults: - run: - shell: bash - working-directory: ./packages/webawesome jobs: client_test: @@ -35,10 +31,17 @@ jobs: run: npm ci - name: Lint run: npm run prettier + working-directory: ./packages/webawesome + - name: Build run: npm run build + working-directory: ./packages/webawesome + - name: Install Playwright run: npx playwright install --with-deps + working-directory: ./packages/webawesome + - name: Run CSR tests # FAIL_FAST to fail on first failing test. run: FAIL_FAST="true" CSR_ONLY="true" npm run test + working-directory: ./packages/webawesome diff --git a/.github/workflows/ssr_tests.yml b/.github/workflows/ssr_tests.yml index eba1d83c7..5e5f1cf7e 100644 --- a/.github/workflows/ssr_tests.yml +++ b/.github/workflows/ssr_tests.yml @@ -8,11 +8,6 @@ on: # branches: [next] workflow_dispatch: -defaults: - run: - shell: bash - working-directory: ./packages/webawesome - jobs: ssr_test: runs-on: ubuntu-latest @@ -31,17 +26,17 @@ jobs: cache: 'npm' - name: Install dependencies run: npm ci - # Just lint here too. Save some GH Action minutes and not need to use "depends_on" or anything. - - name: Lint - run: npm run prettier - name: Build run: npm run build + working-directory: ./packages/webawesome - name: Install Playwright run: npx playwright install --with-deps + working-directory: ./packages/webawesome - name: Run SSR tests # FAIL_FAST to fail on first failing test. run: FAIL_FAST="true" SSR_ONLY="true" npm run test + working-directory: ./packages/webawesome diff --git a/packages/webawesome/docs/_includes/head.njk b/packages/webawesome/docs/_includes/head.njk index 38dc3495d..5c12415c6 100644 --- a/packages/webawesome/docs/_includes/head.njk +++ b/packages/webawesome/docs/_includes/head.njk @@ -32,12 +32,11 @@ {# Fallback loading when using the free repo #} - - `; - -async function render() { - await customElements.whenDefined('wa-checkbox'); - - // Let checkboxes update their "state" - await Promise.allSettled( - Array.from(fieldset.querySelectorAll('wa-checkbox[name=slot]')).map(checkbox => { - return checkbox.updateComplete; - }), - ); - - let slots = Array.from(fieldset.querySelectorAll('wa-checkbox[name=slot]:state(checked)')); - let slotsHTML = slots - .map(slot => { - let name = slot.getAttribute('value'); - let description = slot.getAttribute('data-description'); - - let tag = 'div'; - if (name.endsWith('header')) { - tag = 'header'; - } - if (name.endsWith('footer')) { - tag = 'footer'; - } - - return `<${tag} class="slot-content" slot="${name}"> - ${name || 'main (default)'} -
${description}
- ${tag}>`; - }) - .join('\n'); - let page = iframe.contentDocument?.querySelector('wa-page'); - - if (page) { - page.innerHTML = slotsHTML; - } else { - iframe.srcdoc = `${includes}