From 97bd88f904b52dc31f18aa6b53a0bafa6d0c747b Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Tue, 12 Sep 2023 12:25:08 -0400 Subject: [PATCH] fix link buttons --- package.json | 16 +++------------- src/components/button/button.component.ts | 6 +----- 2 files changed, 4 insertions(+), 18 deletions(-) diff --git a/package.json b/package.json index c7bf9ef1b..51bdfb67c 100644 --- a/package.json +++ b/package.json @@ -25,15 +25,8 @@ "./dist/react/*": "./dist/react/*", "./dist/translations/*": "./dist/translations/*" }, - "files": [ - "dist", - "cdn" - ], - "keywords": [ - "web components", - "custom elements", - "components" - ], + "files": ["dist", "cdn"], + "keywords": ["web components", "custom elements", "components"], "repository": { "type": "git", "url": "git+https://github.com/shoelace-style/shoelace.git" @@ -136,9 +129,6 @@ "user-agent-data-types": "^0.3.0" }, "lint-staged": { - "*.{ts,js}": [ - "eslint --max-warnings 0 --cache --fix", - "prettier --write" - ] + "*.{ts,js}": ["eslint --max-warnings 0 --cache --fix", "prettier --write"] } } diff --git a/src/components/button/button.component.ts b/src/components/button/button.component.ts index 910cc8d05..ad05d4184 100644 --- a/src/components/button/button.component.ts +++ b/src/components/button/button.component.ts @@ -180,7 +180,7 @@ export default class WaButton extends WebAwesomeElement implements WebAwesomeFor this.emit('wa-focus'); } - private handleClick(event: MouseEvent) { + private handleClick() { if (this.type === 'submit') { this.formControlController.submit(this); } @@ -188,10 +188,6 @@ export default class WaButton extends WebAwesomeElement implements WebAwesomeFor if (this.type === 'reset') { this.formControlController.reset(this); } - - if (this.href) { - event.preventDefault(); - } } private handleInvalid(event: Event) {