From cae50866f973cb71632b2c09acbabdc364f00dd5 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Wed, 12 May 2021 07:42:44 -0400 Subject: [PATCH] remove global [hidden] styles --- docs/resources/changelog.md | 1 + src/styles/base.scss | 4 ---- src/styles/component.scss | 4 ++++ 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/resources/changelog.md b/docs/resources/changelog.md index bcca3facd..22aca0fc2 100644 --- a/docs/resources/changelog.md +++ b/docs/resources/changelog.md @@ -15,6 +15,7 @@ _During the beta period, these restrictions may be relaxed in the event of a mis - Fixed a bug that prevented the project from being built in a Windows environment - Improved a11y in `sl-progress-ring` - Removed `src/utilities/index.ts` to prevent tree-shaking confusion (please import utilities directly from their respective modules) +- Removed global `[hidden]` styles so they don't affect anything outside of components - Updated to Bootstrap Icons 1.5.0 - Updated React docs to use [`@shoelace-style/react`](https://github.com/shoelace-style/react) - Updated NextJS docs [#434](https://github.com/shoelace-style/shoelace/pull/434) diff --git a/src/styles/base.scss b/src/styles/base.scss index 1d069c7bd..8ad1c4e13 100644 --- a/src/styles/base.scss +++ b/src/styles/base.scss @@ -295,10 +295,6 @@ // Internal utility classes //////////////////////////////////////////////////////////////////////////////////////////////////////////////////////// -[hidden] { - display: none !important; -} - .sl-scroll-lock { overflow: hidden !important; } diff --git a/src/styles/component.scss b/src/styles/component.scss index 6f5640c39..a622d133b 100644 --- a/src/styles/component.scss +++ b/src/styles/component.scss @@ -8,3 +8,7 @@ box-sizing: inherit; } } + +[hidden] { + display: none !important; +}