From 4993b1034f4047167fdd03ab936711989f5b9149 Mon Sep 17 00:00:00 2001 From: Konnor Rogers Date: Wed, 10 Sep 2025 10:32:48 -0400 Subject: [PATCH 1/4] add notes about skips (#1419) * add notes about skips * prettier * re-add support for 'unpublished: true' * prettier --- packages/webawesome/docs/.eleventy.js | 9 +++++++++ packages/webawesome/scripts/build.js | 2 ++ 2 files changed, 11 insertions(+) diff --git a/packages/webawesome/docs/.eleventy.js b/packages/webawesome/docs/.eleventy.js index b8a5c1232..213b86645 100644 --- a/packages/webawesome/docs/.eleventy.js +++ b/packages/webawesome/docs/.eleventy.js @@ -160,6 +160,15 @@ export default async function (eleventyConfig) { // Use our own markdown instance eleventyConfig.setLibrary('md', markdown); + // for files with `unpublished: true`, it will make sure they do not make it into the final build at all, but will be usable in development. + eleventyConfig.addPreprocessor('unpublished', '*', (data, content) => { + if (data.unpublished && process.env.ELEVENTY_RUN_MODE === 'build') { + return false; + } + + return content; + }); + // Add anchors to headings eleventyConfig.addTransform('doc-transforms', function (content) { let doc = HTMLParse(content, { blockTextElements: { code: true } }); diff --git a/packages/webawesome/scripts/build.js b/packages/webawesome/scripts/build.js index 58cda1f2f..8add5c444 100644 --- a/packages/webawesome/scripts/build.js +++ b/packages/webawesome/scripts/build.js @@ -123,6 +123,7 @@ export async function build(options = {}) { function generateReactWrappers() { // Used by webawesome-app to make re-rendering not miserable with extra React file generation. if (process.env.SKIP_SLOW_STEPS === 'true') { + spinner.info('Skipping React Wrapper generation.'); return Promise.resolve(); } @@ -162,6 +163,7 @@ export async function build(options = {}) { async function generateTypes() { // Used by webawesome-app to make re-rendering not miserable with extra TS compilations. if (process.env.SKIP_SLOW_STEPS === 'true') { + spinner.info('Skipping TypeScript compiler.'); return Promise.resolve(); } From 4ac31e06f336652233595d1c76ccc39f76537744 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Wed, 10 Sep 2025 10:38:06 -0400 Subject: [PATCH 2/4] remove whitespace; closes #1417 (#1418) --- .../docs/docs/resources/changelog.md | 1 + .../src/components/format-date/format-date.ts | 33 +++++++++---------- .../components/relative-time/relative-time.ts | 3 +- 3 files changed, 19 insertions(+), 18 deletions(-) diff --git a/packages/webawesome/docs/docs/resources/changelog.md b/packages/webawesome/docs/docs/resources/changelog.md index f612b9714..939135ec8 100644 --- a/packages/webawesome/docs/docs/resources/changelog.md +++ b/packages/webawesome/docs/docs/resources/changelog.md @@ -36,6 +36,7 @@ Components with the Experimental badge sh - Fixed a bug in `` that prevented the value from changing when assigning non-string values to `value` [issue:1323] - Fixed a bug in `` that prevent the picker from staying in the viewport - Fixed a bug that in `` that caused `library`, `family`, `variant` and `name` to not reflect [pr:#1395] +- Fixed a bug in `` and `` that caused spaces to appear before and after the output [#1417] ## 3.0.0-beta.4 diff --git a/packages/webawesome/src/components/format-date/format-date.ts b/packages/webawesome/src/components/format-date/format-date.ts index 6ff0dc2a3..c3042dabd 100644 --- a/packages/webawesome/src/components/format-date/format-date.ts +++ b/packages/webawesome/src/components/format-date/format-date.ts @@ -66,23 +66,22 @@ export default class WaFormatDate extends WebAwesomeElement { return undefined; } - return html` - - `; + const displayDate = this.localize.date(date, { + weekday: this.weekday, + era: this.era, + year: this.year, + month: this.month, + day: this.day, + hour: this.hour, + minute: this.minute, + second: this.second, + timeZoneName: this.timeZoneName, + timeZone: this.timeZone, + hour12: hour12, + }); + + // No whitespace before or after + return html``; } } diff --git a/packages/webawesome/src/components/relative-time/relative-time.ts b/packages/webawesome/src/components/relative-time/relative-time.ts index 29969924d..79bceb0a0 100644 --- a/packages/webawesome/src/components/relative-time/relative-time.ts +++ b/packages/webawesome/src/components/relative-time/relative-time.ts @@ -99,7 +99,8 @@ export default class WaRelativeTime extends WebAwesomeElement { this.updateTimeout = setTimeout(() => this.requestUpdate(), nextInterval); } - return html` `; + // No whitespace before or after + return html``; } } From ac20e495d9065b754d21d6ba9764e70a1afedc5c Mon Sep 17 00:00:00 2001 From: trent Date: Wed, 10 Sep 2025 10:53:17 -0400 Subject: [PATCH 3/4] allow bundlers access to package.json (#1415) --- packages/webawesome/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/webawesome/package.json b/packages/webawesome/package.json index 544445b21..67c4f0f36 100644 --- a/packages/webawesome/package.json +++ b/packages/webawesome/package.json @@ -29,7 +29,8 @@ "./dist/react": "./dist/react/index.js", "./dist/react/*": "./dist/react/*", "./dist/translations": "./dist/translations", - "./dist/translations/*": "./dist/translations/*" + "./dist/translations/*": "./dist/translations/*", + "./package.json": "./package.json" }, "files": [ "README.md", From 26b29189db6a674311d531564ae6ddfca8b5a1fd Mon Sep 17 00:00:00 2001 From: Brian Talbot Date: Wed, 10 Sep 2025 10:53:38 -0400 Subject: [PATCH 4/4] fixing GitHub discussion links to point to webawesome project (#1425) --- packages/webawesome/docs/docs/localization.md | 2 +- packages/webawesome/docs/docs/resources/accessibility.md | 2 +- packages/webawesome/docs/docs/resources/community.md | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/webawesome/docs/docs/localization.md b/packages/webawesome/docs/docs/localization.md index dfb3b6bd6..3a4323229 100644 --- a/packages/webawesome/docs/docs/localization.md +++ b/packages/webawesome/docs/docs/localization.md @@ -56,7 +56,7 @@ To contribute new translations or improvements to existing translations, please Regional translations are welcome! For example, if a German translation (`de`) exists it's perfectly acceptable to submit a German (Switzerland) (`de-CH`) translation. -If you have any questions, please start a [discussion](https://github.com/shoelace-style/shoelace/discussions) or ask in the [community chat](https://discord.gg/mg8f26C). +If you have any questions, please start a [discussion](https://github.com/shoelace-style/webawesome/discussions) or ask in the [community chat](https://discord.gg/mg8f26C). :::info Web Awesome provides a localization mechanism for component internals. This is not designed to be used as localization tool for your entire application. You should use a more appropriate tool such as [i18next](https://www.i18next.com/) if you need to localize content in your app. diff --git a/packages/webawesome/docs/docs/resources/accessibility.md b/packages/webawesome/docs/docs/resources/accessibility.md index f24c79aba..78d393e77 100644 --- a/packages/webawesome/docs/docs/resources/accessibility.md +++ b/packages/webawesome/docs/docs/resources/accessibility.md @@ -14,7 +14,7 @@ Furthermore, accessibility doesn’t stop at the component level. Using accessib My commitment to Web Awesome users is this: Everything we develop will be built with accessibility in mind. We will test and improve every component to the best of our ability and knowledge. We will work around upstream issues, such as browser bugs and limitations, to the best of our ability and within reason. -We’re fully aware that we may not get it right every time for every user, so we invite the community to participate in this ongoing effort by submitting [issues](https://github.com/shoelace-style/shoelace/issues?q=is%3Aissue+is%3Aopen+label%3Aa11y), [pull requests](https://github.com/shoelace-style/shoelace/pulls?q=is%3Aopen+is%3Apr+label%3Aa11y), and [discussions](https://github.com/shoelace-style/shoelace/discussions). Many accessibility improvements have already been made thanks to contributors submitting code, feedback, and suggestions. +We’re fully aware that we may not get it right every time for every user, so we invite the community to participate in this ongoing effort by submitting [issues](https://github.com/shoelace-style/shoelace/issues?q=is%3Aissue+is%3Aopen+label%3Aa11y), [pull requests](https://github.com/shoelace-style/shoelace/pulls?q=is%3Aopen+is%3Apr+label%3Aa11y), and [discussions](https://github.com/shoelace-style/webawesome/discussions). Many accessibility improvements have already been made thanks to contributors submitting code, feedback, and suggestions. This is the path forward. Together, we will continue to make Web Awesome accessible to as many users as possible. diff --git a/packages/webawesome/docs/docs/resources/community.md b/packages/webawesome/docs/docs/resources/community.md index 66b5805ce..e323a9ec0 100644 --- a/packages/webawesome/docs/docs/resources/community.md +++ b/packages/webawesome/docs/docs/resources/community.md @@ -10,14 +10,14 @@ Please be respectful of other users and remember that Web Awesome is an open sou ## Discussion Forum -The [discussion forum](https://github.com/shoelace-style/shoelace/discussions) is open to anyone with a GitHub account. This is the best place to: +The [discussion forum](https://github.com/shoelace-style/webawesome/discussions) is open to anyone with a GitHub account. This is the best place to: - Ask for help - Share ideas and get feedback - Show the community what you're working on - Learn more about the project, its values, and its roadmap - + Join the Discussion @@ -40,9 +40,9 @@ The [community chat](https://discord.gg/mg8f26C) is open to the public and power Follow [@webawesomer](https://twitter.com/webawesomer) on Twitter for general updates and announcements about Web Awesome. This is a great place to say "hi" or to share something you're working on. -**Please avoid using Twitter for support questions.** The [discussion forum](https://github.com/shoelace-style/shoelace/discussions) is a much better place to share code snippets, screenshots, and other troubleshooting info. You'll have much better luck there, as more users will have a chance to help you. +**Please avoid using Twitter for support questions.** The [discussion forum](https://github.com/shoelace-style/webawesome/discussions) is a much better place to share code snippets, screenshots, and other troubleshooting info. You'll have much better luck there, as more users will have a chance to help you. Follow on Twitter - \ No newline at end of file +