From d77f543c8fe76cd5b08739a22b9fc70a51d2a4ec Mon Sep 17 00:00:00 2001
From: Cory LaViska <cory@abeautifulsite.net>
Date: Fri, 4 Mar 2022 10:08:59 -0500
Subject: [PATCH] fix menu styles

---
 src/components/color-picker/color-picker.styles.ts | 3 +++
 src/components/dropdown/dropdown.styles.ts         | 3 ---
 src/components/menu-item/menu-item.ts              | 2 +-
 src/components/select/select.styles.ts             | 4 ----
 4 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/src/components/color-picker/color-picker.styles.ts b/src/components/color-picker/color-picker.styles.ts
index 76190ace4..48677cc41 100644
--- a/src/components/color-picker/color-picker.styles.ts
+++ b/src/components/color-picker/color-picker.styles.ts
@@ -263,6 +263,9 @@ export default css`
 
   .color-dropdown::part(panel) {
     max-height: none;
+    background-color: var(--sl-panel-background-color);
+    border: solid var(--sl-panel-border-width) var(--sl-panel-border-color);
+    border-radius: var(--sl-border-radius-medium);
     overflow: visible;
   }
 
diff --git a/src/components/dropdown/dropdown.styles.ts b/src/components/dropdown/dropdown.styles.ts
index 14a426d1f..0087a5f53 100644
--- a/src/components/dropdown/dropdown.styles.ts
+++ b/src/components/dropdown/dropdown.styles.ts
@@ -26,9 +26,6 @@ export default css`
     font-size: var(--sl-font-size-medium);
     font-weight: var(--sl-font-weight-normal);
     color: var(--color);
-    background-color: var(--sl-panel-background-color);
-    border: solid var(--sl-panel-border-width) var(--sl-panel-border-color);
-    border-radius: var(--sl-border-radius-medium);
     box-shadow: var(--sl-shadow-large);
     overflow: auto;
     overscroll-behavior: none;
diff --git a/src/components/menu-item/menu-item.ts b/src/components/menu-item/menu-item.ts
index 8bc76e220..6a4267c95 100644
--- a/src/components/menu-item/menu-item.ts
+++ b/src/components/menu-item/menu-item.ts
@@ -57,7 +57,7 @@ export default class SlMenuItem extends LitElement {
           'menu-item': true,
           'menu-item--checked': this.checked,
           'menu-item--disabled': this.disabled,
-          'menu-item--has-submenu': false
+          'menu-item--has-submenu': false // reserved for future use
         })}
       >
         <span class="menu-item__check">
diff --git a/src/components/select/select.styles.ts b/src/components/select/select.styles.ts
index b4c796144..6cdd0154d 100644
--- a/src/components/select/select.styles.ts
+++ b/src/components/select/select.styles.ts
@@ -34,10 +34,6 @@ export default css`
     overflow: auto;
   }
 
-  .select__menu::part(base) {
-    border: none;
-  }
-
   /* Standard selects */
   .select--standard .select__control {
     background-color: var(--sl-input-background-color);