From e48243b492e1b0dba752ac806da4b11c90be7bf0 Mon Sep 17 00:00:00 2001 From: Cory LaViska Date: Wed, 23 Oct 2024 16:07:54 -0400 Subject: [PATCH] backport SL-2226 --- docs/docs/resources/changelog.md | 1 + src/components/tooltip/tooltip.ts | 2 ++ 2 files changed, 3 insertions(+) diff --git a/docs/docs/resources/changelog.md b/docs/docs/resources/changelog.md index 5d09d4507..e3906e6dc 100644 --- a/docs/docs/resources/changelog.md +++ b/docs/docs/resources/changelog.md @@ -16,6 +16,7 @@ During the alpha period, things might break! We take breaking changes very serio - Fixed a bug in `` where the title attribute would show with redundant info - Added more resilient support for lazy loaded options in `` +- Fixed a bug in `` that caused a memory leak in disconnected elements ## 3.0.0-alpha.3 diff --git a/src/components/tooltip/tooltip.ts b/src/components/tooltip/tooltip.ts index ec76788f6..6ae8ccbd5 100644 --- a/src/components/tooltip/tooltip.ts +++ b/src/components/tooltip/tooltip.ts @@ -129,6 +129,8 @@ export default class WaTooltip extends WebAwesomeElement { } disconnectedCallback() { + super.disconnectedCallback(); + // Cleanup this event in case the tooltip is removed while open this.closeWatcher?.destroy(); document.removeEventListener('keydown', this.handleDocumentKeyDown);