Fix details focus ring (#1464)

* remove duplicate styles, fix focus outline

* update native details focus ring and rounding
This commit is contained in:
Lindsay M
2025-09-18 11:15:54 -04:00
committed by GitHub
parent 0beceff73f
commit fcf37f83a1
2 changed files with 15 additions and 27 deletions

View File

@@ -6,29 +6,6 @@
display: block;
}
:host summary {
display: flex;
align-items: center;
justify-content: space-between;
user-select: none;
-webkit-user-select: none;
cursor: pointer;
&::marker,
&::-webkit-details-marker {
display: none;
}
&:focus {
outline: none;
}
&:focus-visible {
outline: var(--wa-focus-ring);
outline-offset: calc(var(--spacing) + var(--wa-focus-ring-offset));
}
}
details {
display: block;
overflow-anchor: none;
@@ -77,15 +54,16 @@ details {
cursor: not-allowed;
}
:host summary {
summary {
display: flex;
align-items: center;
justify-content: space-between;
gap: var(--spacing);
padding: var(--spacing); /* Add padding here */
border-radius: calc(var(--wa-panel-border-radius) - var(--wa-panel-border-width));
user-select: none;
-webkit-user-select: none;
cursor: pointer;
padding: var(--spacing); /* Add padding here */
&::marker,
&::-webkit-details-marker {
@@ -98,10 +76,15 @@ details {
&:focus-visible {
outline: var(--wa-focus-ring);
outline-offset: calc(var(--spacing) + var(--wa-focus-ring-offset));
outline-offset: calc(var(--wa-panel-border-width) + var(--wa-focus-ring-offset));
}
}
:host([open]) summary {
border-end-start-radius: 0;
border-end-end-radius: 0;
}
/* 'Start' icon placement */
:host([icon-placement='start']) summary {
flex-direction: row-reverse;

View File

@@ -407,6 +407,8 @@
padding: var(--wa-space-m);
border-radius: calc(var(--wa-panel-border-radius) - var(--wa-panel-border-width));
cursor: pointer;
user-select: none;
-webkit-user-select: none;
@@ -421,7 +423,7 @@
&:focus-visible {
outline: var(--wa-focus-ring);
outline-offset: var(--wa-focus-ring-offset);
outline-offset: calc(var(--wa-panel-border-width) + var(--wa-focus-ring-offset));
}
}
@@ -430,6 +432,9 @@
summary {
margin-inline: calc(-1 * var(--wa-space-m));
border-end-start-radius: 0;
border-end-end-radius: 0;
}
}