fix: error not as pointer

cid.go

@@ -456,7 +456,7 @@ func (c Cid) Equals(o Cid) bool {
 // UnmarshalJSON parses the JSON representation of a Cid.
 func (c *Cid) UnmarshalJSON(b []byte) error {
 	if len(b) < 2 {
-		return ErrInvalidCid{fmt.Errorf("invalid cid json blob")}
+		return fmt.Errorf("invalid cid json blob")
 	}
 	obj := struct {
 		CidTarget string `json:"/"`
@@ -464,7 +464,7 @@ func (c *Cid) UnmarshalJSON(b []byte) error {
 	objptr := &obj
 	err := json.Unmarshal(b, &objptr)
 	if err != nil {
-		return ErrInvalidCid{err}
+		return err
 	}
 	if objptr == nil {
 		*c = Cid{}
@@ -472,12 +472,12 @@ func (c *Cid) UnmarshalJSON(b []byte) error {
 	}
 
 	if obj.CidTarget == "" {
-		return ErrInvalidCid{fmt.Errorf("cid was incorrectly formatted")}
+		return fmt.Errorf("cid was incorrectly formatted")
 	}
 
 	out, err := Decode(obj.CidTarget)
 	if err != nil {
-		return ErrInvalidCid{err}
+		return err
 	}
 
 	*c = out
@@ -564,12 +564,12 @@ func (p Prefix) Sum(data []byte) (Cid, error) {
 	if p.Version == 0 && (p.MhType != mh.SHA2_256 ||
 		(p.MhLength != 32 && p.MhLength != -1)) {
 
-		return Undef, ErrInvalidCid{fmt.Errorf("invalid v0 prefix")}
+		return Undef, fmt.Errorf("invalid v0 prefix")
 	}
 
 	hash, err := mh.Sum(data, p.MhType, length)
 	if err != nil {
-		return Undef, ErrInvalidCid{err}
+		return Undef, err
 	}
 
 	switch p.Version {
@@ -578,7 +578,7 @@ func (p Prefix) Sum(data []byte) (Cid, error) {
 	case 1:
 		return NewCidV1(p.Codec, hash), nil
 	default:
-		return Undef, ErrInvalidCid{fmt.Errorf("invalid cid version")}
+		return Undef, fmt.Errorf("invalid cid version")
 	}
 }
 
@@ -608,22 +608,22 @@ func PrefixFromBytes(buf []byte) (Prefix, error) {
 	r := bytes.NewReader(buf)
 	vers, err := varint.ReadUvarint(r)
 	if err != nil {
-		return Prefix{}, ErrInvalidCid{err}
+		return Prefix{}, err
 	}
 
 	codec, err := varint.ReadUvarint(r)
 	if err != nil {
-		return Prefix{}, ErrInvalidCid{err}
+		return Prefix{}, err
 	}
 
 	mhtype, err := varint.ReadUvarint(r)
 	if err != nil {
-		return Prefix{}, ErrInvalidCid{err}
+		return Prefix{}, err
 	}
 
 	mhlen, err := varint.ReadUvarint(r)
 	if err != nil {
-		return Prefix{}, ErrInvalidCid{err}
+		return Prefix{}, err
 	}
 
 	return Prefix{
@@ -717,9 +717,6 @@ func (r *bufByteReader) ReadByte() (byte, error) {
 // It's recommended to supply a reader that buffers and implements io.ByteReader,
 // as CidFromReader has to do many single-byte reads to decode varints.
 // If the argument only implements io.Reader, single-byte Read calls are used instead.
-//
-// If the Reader is found to yield zero bytes, an io.EOF error is returned directly, in all
-// other error cases, an ErrInvalidCid, wrapping the original error, is returned.
 func CidFromReader(r io.Reader) (int, Cid, error) {
 	// 64 bytes is enough for any CIDv0,
 	// and it's enough for most CIDv1s in practice.
@@ -730,11 +727,6 @@ func CidFromReader(r io.Reader) (int, Cid, error) {
 	// The varint package wants a io.ByteReader, so we must wrap our io.Reader.
 	vers, err := varint.ReadUvarint(br)
 	if err != nil {
-		if err == io.EOF {
-			// First-byte read in ReadUvarint errors with io.EOF, so reader has no data.
-			// Subsequent reads with an EOF will return io.ErrUnexpectedEOF and be wrapped here.
-			return 0, Undef, err
-		}
 		return len(br.dst), Undef, ErrInvalidCid{err}
 	}
 

cid_test.go

@@ -163,9 +163,6 @@ func TestBasesMarshaling(t *testing.T) {
 	if err == nil {
 		t.Fatal("expected too-short error from ExtractEncoding")
 	}
-	if !errors.Is(err, ErrInvalidCid{}) {
-		t.Fatal("expected error to be ErrInvalidCid")
-	}
 	if ee != -1 {
 		t.Fatal("expected -1 from too-short ExtractEncoding")
 	}
@@ -382,9 +379,6 @@ func TestInvalidV0Prefix(t *testing.T) {
 		if err == nil {
 			t.Fatalf("should error (index %d)", i)
 		}
-		if !errors.Is(err, ErrInvalidCid{}) {
-			t.Fatal("expected error to be ErrInvalidCid")
-		}
 	}
 }
 
@@ -394,9 +388,6 @@ func TestBadPrefix(t *testing.T) {
 	if err == nil {
 		t.Fatalf("expected error on v3 prefix Sum")
 	}
-	if !errors.Is(err, ErrInvalidCid{}) {
-		t.Fatal("expected error to be ErrInvalidCid")
-	}
 }
 
 func TestPrefixRoundtrip(t *testing.T) {
@@ -433,30 +424,18 @@ func TestBadPrefixFromBytes(t *testing.T) {
 	if err == nil {
 		t.Fatal("expected error for bad byte 0")
 	}
-	if !errors.Is(err, ErrInvalidCid{}) {
-		t.Fatal("expected error to be ErrInvalidCid")
-	}
 	_, err = PrefixFromBytes([]byte{0x01, 0x80})
 	if err == nil {
 		t.Fatal("expected error for bad byte 1")
 	}
-	if !errors.Is(err, ErrInvalidCid{}) {
-		t.Fatal("expected error to be ErrInvalidCid")
-	}
 	_, err = PrefixFromBytes([]byte{0x01, 0x01, 0x80})
 	if err == nil {
 		t.Fatal("expected error for bad byte 2")
 	}
-	if !errors.Is(err, ErrInvalidCid{}) {
-		t.Fatal("expected error to be ErrInvalidCid")
-	}
 	_, err = PrefixFromBytes([]byte{0x01, 0x01, 0x01, 0x80})
 	if err == nil {
 		t.Fatal("expected error for bad byte 3")
 	}
-	if !errors.Is(err, ErrInvalidCid{}) {
-		t.Fatal("expected error to be ErrInvalidCid")
-	}
 }
 
 func Test16BytesVarint(t *testing.T) {
@@ -603,29 +582,17 @@ func TestJsonRoundTrip(t *testing.T) {
 		t.Fatal("cids not equal for Cid")
 	}
 
-	err = actual2.UnmarshalJSON([]byte("1"))
-	if err == nil {
+	if err = actual2.UnmarshalJSON([]byte("1")); err == nil {
 		t.Fatal("expected error for too-short JSON")
 	}
-	if !errors.Is(err, ErrInvalidCid{}) {
-		t.Fatal("expected error to be ErrInvalidCid")
-	}
 
-	err = actual2.UnmarshalJSON([]byte(`{"nope":"nope"}`))
-	if err == nil {
+	if err = actual2.UnmarshalJSON([]byte(`{"nope":"nope"}`)); err == nil {
 		t.Fatal("expected error for bad CID JSON")
 	}
-	if !errors.Is(err, ErrInvalidCid{}) {
-		t.Fatal("expected error to be ErrInvalidCid")
-	}
 
-	err = actual2.UnmarshalJSON([]byte(`bad "" json!`))
-	if err == nil {
+	if err = actual2.UnmarshalJSON([]byte(`bad "" json!`)); err == nil {
 		t.Fatal("expected error for bad JSON")
 	}
-	if !errors.Is(err, ErrInvalidCid{}) {
-		t.Fatal("expected error to be ErrInvalidCid")
-	}
 
 	var actual3 Cid
 	enc, err = actual3.MarshalJSON()
@@ -783,30 +750,6 @@ func TestBadCidInput(t *testing.T) {
 	}
 }
 
-func TestFromReaderNoData(t *testing.T) {
-	// Reading no data from io.Reader should return io.EOF, not ErrInvalidCid.
-	n, cid, err := CidFromReader(bytes.NewReader(nil))
-	if err != io.EOF {
-		t.Fatal("Expected io.EOF error")
-	}
-	if cid != Undef {
-		t.Fatal("Expected Undef CID")
-	}
-	if n != 0 {
-		t.Fatal("Expected 0 data")
-	}
-
-	// Read byte indicatiing more data to and check error is ErrInvalidCid.
-	_, _, err = CidFromReader(bytes.NewReader([]byte{0x80}))
-	if !errors.Is(err, ErrInvalidCid{}) {
-		t.Fatal("Expected ErrInvalidCid error")
-	}
-	// Check for expected wrapped error.
-	if !errors.Is(err, io.ErrUnexpectedEOF) {
-		t.Fatal("Expected error", io.ErrUnexpectedEOF)
-	}
-}
-
 func TestBadParse(t *testing.T) {
 	hash, err := mh.Sum([]byte("foobar"), mh.SHA3_256, -1)
 	if err != nil {
@@ -834,79 +777,14 @@ func TestLoggable(t *testing.T) {
 	}
 }
 
-func TestErrInvalidCidIs(t *testing.T) {
-	for i, test := range []struct {
-		err    error
-		target error
-	}{
-		{&ErrInvalidCid{}, ErrInvalidCid{}},
-		{ErrInvalidCid{}, &ErrInvalidCid{}},
-		{ErrInvalidCid{}, ErrInvalidCid{}},
-		{&ErrInvalidCid{}, &ErrInvalidCid{}},
-	} {
-		if !errors.Is(test.err, test.target) {
-			t.Fatalf("expected error to be ErrInvalidCid, case %d", i)
-		}
-	}
-}
-
 func TestErrInvalidCid(t *testing.T) {
-	run := func(err error) {
-		if err == nil {
-			t.Fatal("expected error")
-		}
-
-		if !strings.HasPrefix(err.Error(), "invalid cid: ") {
-			t.Fatal(`expected error message to contain "invalid cid: "`)
-		}
-
-		is := errors.Is(err, ErrInvalidCid{})
-		if !is {
-			t.Fatal("expected error to be ErrInvalidCid")
-		}
-
-		if !errors.Is(err, &ErrInvalidCid{}) {
-			t.Fatal("expected error to be &ErrInvalidCid")
-		}
+	_, err := Decode("not-a-cid")
+	if err == nil {
+		t.Fatal("expected error")
 	}
 
-	_, err := Decode("")
-	run(err)
-
-	_, err = Decode("not-a-cid")
-	run(err)
-
-	_, err = Decode("bafyInvalid")
-	run(err)
-
-	_, err = Decode("QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zIII")
-	run(err)
-
-	_, err = Cast([]byte("invalid"))
-	run(err)
-
-	_, err = Parse("not-a-cid")
-	run(err)
-
-	_, err = Parse("bafyInvalid")
-	run(err)
-
-	_, err = Parse("QmdfTbBqBPQ7VNxZEYEj14VmRuZBkqFbiwReogJgS1zIII")
-	run(err)
-
-	_, err = Parse(123)
-	run(err)
-
-	_, _, err = CidFromBytes([]byte("invalid"))
-	run(err)
-
-	_, err = Prefix{}.Sum([]byte("data"))
-	run(err)
-
-	_, err = PrefixFromBytes([]byte{0x80})
-	run(err)
-
-	_, err = ExtractEncoding("invalid ")
-	run(err)
-
+	is := errors.Is(err, ErrInvalidCid{})
+	if !is {
+		t.Fatal("expected error to be ErrInvalidCid")
+	}
 }

version.json

@@ -1,3 +1,3 @@
 {
-  "version": "v0.4.1"
+  "version": "v0.3.2"
 }