More tests.

driver/driver.go

@@ -543,7 +543,7 @@ func (r *rows) Next(dest []driver.Value) error {
 }
 
 func (s *stmt) decodeTime(i int) (_ time.Time, _ bool) {
-	if s.tmRead == "" {
+	if s.tmRead == sqlite3.TimeFormatDefault {
 		return
 	}
 	switch s.Stmt.ColumnType(i) {

driver/driver_test.go

@@ -6,6 +6,7 @@ import (
 	"database/sql"
 	"errors"
 	"math"
+	"net/url"
 	"path/filepath"
 	"testing"
 	"time"
@@ -295,3 +296,39 @@ func Test_QueryRow_blob_null(t *testing.T) {
 		}
 	}
 }
+
+func Test_time(t *testing.T) {
+	t.Parallel()
+
+	for _, fmt := range []string{"auto", "sqlite", "rfc3339", time.ANSIC} {
+		t.Run(fmt, func(t *testing.T) {
+			db, err := sql.Open("sqlite3", "file::memory:?_timefmt="+url.QueryEscape(fmt))
+			if err != nil {
+				t.Fatal(err)
+			}
+			defer db.Close()
+
+			twosday := time.Date(2022, 2, 22, 22, 22, 22, 0, time.UTC)
+
+			_, err = db.Exec(`CREATE TABLE IF NOT EXISTS test (at DATETIME)`)
+			if err != nil {
+				t.Fatal(err)
+			}
+
+			_, err = db.Exec(`INSERT INTO test VALUES (?)`, twosday)
+			if err != nil {
+				t.Fatal(err)
+			}
+
+			var got time.Time
+			err = db.QueryRow(`SELECT * FROM test`).Scan(&got)
+			if err != nil {
+				t.Fatal(err)
+			}
+
+			if !got.Equal(twosday) {
+				t.Errorf("got: %v", got)
+			}
+		})
+	}
+}

ext/fileio/write_test.go

@@ -60,7 +60,7 @@ func Test_writefile(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
-		if mode.IsDir() && mtime != twosday {
+		if mode.IsDir() && !mtime.Equal(twosday) {
 			t.Errorf("got: %v", mtime)
 		}
 		if mode.IsRegular() && data.String != "Hello world!" {

ext/pivot/op_test.go

@@ -0,0 +1,34 @@
+package pivot
+
+import (
+	"testing"
+
+	"github.com/ncruces/go-sqlite3"
+)
+
+func Test_operator(t *testing.T) {
+	tests := []struct {
+		op   sqlite3.IndexConstraintOp
+		want string
+	}{
+		{sqlite3.INDEX_CONSTRAINT_EQ, "="},
+		{sqlite3.INDEX_CONSTRAINT_LT, "<"},
+		{sqlite3.INDEX_CONSTRAINT_GT, ">"},
+		{sqlite3.INDEX_CONSTRAINT_LE, "<="},
+		{sqlite3.INDEX_CONSTRAINT_GE, ">="},
+		{sqlite3.INDEX_CONSTRAINT_NE, "<>"},
+		{sqlite3.INDEX_CONSTRAINT_IS, "IS"},
+		{sqlite3.INDEX_CONSTRAINT_ISNOT, "IS NOT"},
+		{sqlite3.INDEX_CONSTRAINT_REGEXP, "REGEXP"},
+		{sqlite3.INDEX_CONSTRAINT_MATCH, "MATCH"},
+		{sqlite3.INDEX_CONSTRAINT_GLOB, "GLOB"},
+		{sqlite3.INDEX_CONSTRAINT_LIKE, "LIKE"},
+	}
+	for _, tt := range tests {
+		t.Run(tt.want, func(t *testing.T) {
+			if got := operator(tt.op); got != tt.want {
+				t.Errorf("operator() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}

ext/pivot/pivot.go

@@ -114,34 +114,8 @@ func (t *table) BestIndex(idx *sqlite3.IndexInfo) error {
 		if !cst.Usable || !(0 <= cst.Column && cst.Column < len(t.keys)) {
 			continue
 		}
-
-		var op string
-		switch cst.Op {
-		case sqlite3.INDEX_CONSTRAINT_EQ:
-			op = "="
-		case sqlite3.INDEX_CONSTRAINT_LT:
-			op = "<"
-		case sqlite3.INDEX_CONSTRAINT_GT:
-			op = ">"
-		case sqlite3.INDEX_CONSTRAINT_LE:
-			op = "<="
-		case sqlite3.INDEX_CONSTRAINT_GE:
-			op = ">="
-		case sqlite3.INDEX_CONSTRAINT_NE:
-			op = "<>"
-		case sqlite3.INDEX_CONSTRAINT_MATCH:
-			op = "MATCH"
-		case sqlite3.INDEX_CONSTRAINT_LIKE:
-			op = "LIKE"
-		case sqlite3.INDEX_CONSTRAINT_GLOB:
-			op = "GLOB"
-		case sqlite3.INDEX_CONSTRAINT_REGEXP:
-			op = "REGEXP"
-		case sqlite3.INDEX_CONSTRAINT_IS, sqlite3.INDEX_CONSTRAINT_ISNULL:
-			op = "IS"
-		case sqlite3.INDEX_CONSTRAINT_ISNOT, sqlite3.INDEX_CONSTRAINT_ISNOTNULL:
-			op = "IS NOT"
-		default:
+		op := operator(cst.Op)
+		if op == "" {
 			continue
 		}
 
@@ -265,3 +239,34 @@ func (c *cursor) Column(ctx *sqlite3.Context, col int) error {
 	}
 	return c.cell.Reset()
 }
+
+func operator(op sqlite3.IndexConstraintOp) string {
+	switch op {
+	case sqlite3.INDEX_CONSTRAINT_EQ:
+		return "="
+	case sqlite3.INDEX_CONSTRAINT_LT:
+		return "<"
+	case sqlite3.INDEX_CONSTRAINT_GT:
+		return ">"
+	case sqlite3.INDEX_CONSTRAINT_LE:
+		return "<="
+	case sqlite3.INDEX_CONSTRAINT_GE:
+		return ">="
+	case sqlite3.INDEX_CONSTRAINT_NE:
+		return "<>"
+	case sqlite3.INDEX_CONSTRAINT_MATCH:
+		return "MATCH"
+	case sqlite3.INDEX_CONSTRAINT_LIKE:
+		return "LIKE"
+	case sqlite3.INDEX_CONSTRAINT_GLOB:
+		return "GLOB"
+	case sqlite3.INDEX_CONSTRAINT_REGEXP:
+		return "REGEXP"
+	case sqlite3.INDEX_CONSTRAINT_IS, sqlite3.INDEX_CONSTRAINT_ISNULL:
+		return "IS"
+	case sqlite3.INDEX_CONSTRAINT_ISNOT, sqlite3.INDEX_CONSTRAINT_ISNOTNULL:
+		return "IS NOT"
+	default:
+		return ""
+	}
+}