Export logging.

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.33.0 to 0.35.0.
- [Commits](https://github.com/golang/crypto/compare/v0.33.0...v0.35.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

README.md

@@ -98,7 +98,7 @@ Also, post there if you used this driver for something interesting
 ([_"Show and tell"_](https://github.com/ncruces/go-sqlite3/discussions/categories/show-and-tell)),
 have an [idea](https://github.com/ncruces/go-sqlite3/discussions/categories/ideas)…
 
-The [Issue](https://github.com/ncruces/go-sqlite3/issues) tracker is for bugs we want fixed,
+The [Issue](https://github.com/ncruces/go-sqlite3/issues) tracker is for bugs,
 and features we're working on, planning to work on, or asking for help with.
 
 ### Alternatives
@@ -106,4 +106,4 @@ and features we're working on, planning to work on, or asking for help with.
 - [`modernc.org/sqlite`](https://pkg.go.dev/modernc.org/sqlite)
 - [`crawshaw.io/sqlite`](https://pkg.go.dev/crawshaw.io/sqlite)
 - [`github.com/mattn/go-sqlite3`](https://pkg.go.dev/github.com/mattn/go-sqlite3)
-- [`github.com/zombiezen/go-sqlite`](https://pkg.go.dev/github.com/zombiezen/go-sqlite)
+- [`github.com/zombiezen/go-sqlite`](https://pkg.go.dev/github.com/zombiezen/go-sqlite)

conn.go

@@ -3,6 +3,7 @@ package sqlite3
 import (
 	"context"
 	"fmt"
+	"iter"
 	"math"
 	"math/rand"
 	"net/url"
@@ -503,10 +504,16 @@ func (c *Conn) error(rc res_t, sql ...string) error {
 	return c.sqlite.error(rc, c.handle, sql...)
 }
 
-func (c *Conn) stmtsIter(yield func(*Stmt) bool) {
-	for _, s := range c.stmts {
-		if !yield(s) {
-			break
+// Stmts returns an iterator for the prepared statements
+// associated with the database connection.
+//
+// https://sqlite.org/c3ref/next_stmt.html
+func (c *Conn) Stmts() iter.Seq[*Stmt] {
+	return func(yield func(*Stmt) bool) {
+		for _, s := range c.stmts {
+			if !yield(s) {
+				break
+			}
 		}
 	}
 }

conn_iter.go

@@ -1,11 +0,0 @@
-//go:build go1.23
-
-package sqlite3
-
-import "iter"
-
-// Stmts returns an iterator for the prepared statements
-// associated with the database connection.
-//
-// https://sqlite.org/c3ref/next_stmt.html
-func (c *Conn) Stmts() iter.Seq[*Stmt] { return c.stmtsIter }

conn_old.go

@@ -1,9 +0,0 @@
-//go:build !go1.23
-
-package sqlite3
-
-// Stmts returns an iterator for the prepared statements
-// associated with the database connection.
-//
-// https://sqlite.org/c3ref/next_stmt.html
-func (c *Conn) Stmts() func(func(*Stmt) bool) { return c.stmtsIter }

embed/bcw2/build.sh

@@ -17,6 +17,7 @@ cp "$ROOT"/sqlite3/*.patch build/
 curl -# https://sqlite.org/src/tarball/sqlite.tar.gz?r=c09656c6 | tar xz
 
 cd sqlite
+cat ../repro.patch | patch -p0 --no-backup-if-mismatch
 if [[ "$OSTYPE" == "msys" || "$OSTYPE" == "cygwin" ]]; then
 	MSYS_NO_PATHCONV=1 nmake /f makefile.msc sqlite3.c "OPTS=-DSQLITE_ENABLE_UPDATE_DELETE_LIMIT -DSQLITE_ENABLE_ORDERED_SET_AGGREGATES"
 else

embed/bcw2/go.mod

@@ -1,6 +1,6 @@
 module github.com/ncruces/go-sqlite3/embed/bcw2
 
-go 1.22.0
+go 1.23.0
 
 toolchain go1.24.0
 

embed/bcw2/repro.patch

@@ -0,0 +1,23 @@
+# https://sqlite.org/src/vpatch?from=67809715977a5bad&to=3f57584710d61174
+--- tool/mkpragmatab.tcl
++++ tool/mkpragmatab.tcl
+@@ -526,14 +526,17 @@
+   puts $fd [format {#define PragFlg_%-10s 0x%02x /* %s */} \
+              $f $fv $flagMeaning($f)]
+   set fv [expr {$fv*2}]
+ }
+ 
+-# Sort the column lists so that longer column lists occur first
++# Sort the column lists so that longer column lists occur first.
++# In the event of a tie, sort column lists lexicographically.
+ #
+ proc colscmp {a b} {
+-  return [expr {[llength $b] - [llength $a]}]
++  set rc [expr {[llength $b] - [llength $a]}]
++  if {$rc} {return $rc}
++  return [string compare $a $b]
+ }
+ set cols_list [lsort -command colscmp $cols_list]
+ 
+ # Generate the array of column names used by pragmas that act like
+ # queries.

embed/exports.txt

@@ -80,6 +80,7 @@ sqlite3_interrupt
 sqlite3_invoke_busy_handler_go
 sqlite3_last_insert_rowid
 sqlite3_limit
+sqlite3_log_go
 sqlite3_malloc64
 sqlite3_open_v2
 sqlite3_overload_function

ext/fileio/coro.go

@@ -1,70 +0,0 @@
-//go:build !go1.23
-
-package fileio
-
-import (
-	"fmt"
-
-	"github.com/ncruces/go-sqlite3/internal/util"
-)
-
-// Adapted from: https://research.swtch.com/coro
-
-const errCoroCanceled = util.ErrorString("coroutine canceled")
-
-func coroNew[In, Out any](f func(In, func(Out) In) Out) (resume func(In) (Out, bool), cancel func()) {
-	type msg[T any] struct {
-		panic any
-		val   T
-	}
-
-	cin := make(chan msg[In])
-	cout := make(chan msg[Out])
-	running := true
-	resume = func(in In) (out Out, ok bool) {
-		if !running {
-			return
-		}
-		cin <- msg[In]{val: in}
-		m := <-cout
-		if m.panic != nil {
-			panic(m.panic)
-		}
-		return m.val, running
-	}
-	cancel = func() {
-		if !running {
-			return
-		}
-		e := fmt.Errorf("%w", errCoroCanceled)
-		cin <- msg[In]{panic: e}
-		m := <-cout
-		if m.panic != nil && m.panic != e {
-			panic(m.panic)
-		}
-	}
-	yield := func(out Out) In {
-		cout <- msg[Out]{val: out}
-		m := <-cin
-		if m.panic != nil {
-			panic(m.panic)
-		}
-		return m.val
-	}
-	go func() {
-		defer func() {
-			if running {
-				running = false
-				cout <- msg[Out]{panic: recover()}
-			}
-		}()
-		var out Out
-		m := <-cin
-		if m.panic == nil {
-			out = f(m.val, yield)
-		}
-		running = false
-		cout <- msg[Out]{val: out}
-	}()
-	return resume, cancel
-}

ext/fileio/fsdir.go

@@ -2,6 +2,7 @@ package fileio
 
 import (
 	"io/fs"
+	"iter"
 	"os"
 	"path"
 	"path/filepath"
@@ -63,7 +64,7 @@ func (d fsdir) Open() (sqlite3.VTabCursor, error) {
 type cursor struct {
 	fsdir
 	base   string
-	resume resume
+	resume func() (entry, bool)
 	cancel func()
 	curr   entry
 	eof    bool
@@ -101,14 +102,26 @@ func (c *cursor) Filter(idxNum int, idxStr string, arg ...sqlite3.Value) error {
 		c.base = base
 	}
 
-	c.resume, c.cancel = pull(c, root)
+	c.resume, c.cancel = iter.Pull(func(yield func(entry) bool) {
+		walkDir := func(path string, d fs.DirEntry, err error) error {
+			if yield(entry{d, err, path}) {
+				return nil
+			}
+			return fs.SkipAll
+		}
+		if c.fsys != nil {
+			fs.WalkDir(c.fsys, root, walkDir)
+		} else {
+			filepath.WalkDir(root, walkDir)
+		}
+	})
 	c.eof = false
 	c.rowID = 0
 	return c.Next()
 }
 
 func (c *cursor) Next() error {
-	curr, ok := next(c)
+	curr, ok := c.resume()
 	c.curr = curr
 	c.eof = !ok
 	c.rowID++

ext/fileio/fsdir_coro.go

@@ -1,29 +0,0 @@
-//go:build !go1.23
-
-package fileio
-
-import (
-	"io/fs"
-	"path/filepath"
-)
-
-type resume = func(struct{}) (entry, bool)
-
-func next(c *cursor) (entry, bool) {
-	return c.resume(struct{}{})
-}
-
-func pull(c *cursor, root string) (resume, func()) {
-	return coroNew(func(_ struct{}, yield func(entry) struct{}) entry {
-		walkDir := func(path string, d fs.DirEntry, err error) error {
-			yield(entry{d, err, path})
-			return nil
-		}
-		if c.fsys != nil {
-			fs.WalkDir(c.fsys, root, walkDir)
-		} else {
-			filepath.WalkDir(root, walkDir)
-		}
-		return entry{}
-	})
-}

ext/fileio/fsdir_iter.go

@@ -1,31 +0,0 @@
-//go:build go1.23
-
-package fileio
-
-import (
-	"io/fs"
-	"iter"
-	"path/filepath"
-)
-
-type resume = func() (entry, bool)
-
-func next(c *cursor) (entry, bool) {
-	return c.resume()
-}
-
-func pull(c *cursor, root string) (resume, func()) {
-	return iter.Pull(func(yield func(entry) bool) {
-		walkDir := func(path string, d fs.DirEntry, err error) error {
-			if yield(entry{d, err, path}) {
-				return nil
-			}
-			return fs.SkipAll
-		}
-		if c.fsys != nil {
-			fs.WalkDir(c.fsys, root, walkDir)
-		} else {
-			filepath.WalkDir(root, walkDir)
-		}
-	})
-}

func.go

@@ -175,26 +175,24 @@ func stepCallback(ctx context.Context, mod api.Module, pCtx, pAgg, pApp ptr_t, n
 	fn.Step(Context{db, pCtx}, args[:nArg]...)
 }
 
-func finalCallback(ctx context.Context, mod api.Module, pCtx, pAgg, pApp ptr_t) {
+func valueCallback(ctx context.Context, mod api.Module, pCtx, pAgg, pApp ptr_t, final int32) {
 	db := ctx.Value(connKey{}).(*Conn)
 	fn, handle := callbackAggregate(db, pAgg, pApp)
 	fn.Value(Context{db, pCtx})
-	var err error
-	if handle != 0 {
-		err = util.DelHandle(ctx, handle)
-	} else if c, ok := fn.(io.Closer); ok {
-		err = c.Close()
-	}
-	if err != nil {
-		Context{db, pCtx}.ResultError(err)
-		return // notest
-	}
-}
 
-func valueCallback(ctx context.Context, mod api.Module, pCtx, pAgg ptr_t) {
-	db := ctx.Value(connKey{}).(*Conn)
-	fn := util.GetHandle(db.ctx, pAgg).(AggregateFunction)
-	fn.Value(Context{db, pCtx})
+	// Cleanup.
+	if final != 0 {
+		var err error
+		if handle != 0 {
+			err = util.DelHandle(ctx, handle)
+		} else if c, ok := fn.(io.Closer); ok {
+			err = c.Close()
+		}
+		if err != nil {
+			Context{db, pCtx}.ResultError(err)
+			return // notest
+		}
+	}
 }
 
 func inverseCallback(ctx context.Context, mod api.Module, pCtx, pAgg ptr_t, nArg int32, pArg ptr_t) {

go.mod

@@ -1,6 +1,6 @@
 module github.com/ncruces/go-sqlite3
 
-go 1.22.0
+go 1.23.0
 
 toolchain go1.24.0
 
@@ -8,7 +8,7 @@ require (
 	github.com/ncruces/julianday v1.0.0
 	github.com/ncruces/sort v0.1.5
 	github.com/tetratelabs/wazero v1.9.0
-	golang.org/x/crypto v0.33.0
+	golang.org/x/crypto v0.35.0
 	golang.org/x/sys v0.30.0
 )
 

go.sum

@@ -10,8 +10,8 @@ github.com/psanford/httpreadat v0.1.0 h1:VleW1HS2zO7/4c7c7zNl33fO6oYACSagjJIyMIw
 github.com/psanford/httpreadat v0.1.0/go.mod h1:Zg7P+TlBm3bYbyHTKv/EdtSJZn3qwbPwpfZ/I9GKCRE=
 github.com/tetratelabs/wazero v1.9.0 h1:IcZ56OuxrtaEz8UYNRHBrUa9bYeX9oVY93KspZZBf/I=
 github.com/tetratelabs/wazero v1.9.0/go.mod h1:TSbcXCfFP0L2FGkRPxHphadXPjo1T6W+CseNNY7EkjM=
-golang.org/x/crypto v0.33.0 h1:IOBPskki6Lysi0lo9qQvbxiQ+FvsCC/YWOecCHAixus=
-golang.org/x/crypto v0.33.0/go.mod h1:bVdXmD7IV/4GdElGPozy6U7lWdRXA4qyRVGJV57uQ5M=
+golang.org/x/crypto v0.35.0 h1:b15kiHdrGCHrP6LvwaQ3c03kgNhhiMgvlhxHQhmg2Xs=
+golang.org/x/crypto v0.35.0/go.mod h1:dy7dXNW32cAb/6/PRuTNsix8T+vJAqvuIy5Bli/x0YQ=
 golang.org/x/sync v0.11.0 h1:GGz8+XQP4FvTTrjZPzNKTMFtSXH80RAzG+5ghFPgK9w=
 golang.org/x/sync v0.11.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
 golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=

gormlite/go.mod

@@ -1,6 +1,6 @@
 module github.com/ncruces/go-sqlite3/gormlite
 
-go 1.22.0
+go 1.23.0
 
 toolchain go1.24.0
 

sqlite.go

@@ -317,8 +317,7 @@ func exportCallbacks(env wazero.HostModuleBuilder) wazero.HostModuleBuilder {
 	util.ExportFuncVI(env, "go_destroy", destroyCallback)
 	util.ExportFuncVIIII(env, "go_func", funcCallback)
 	util.ExportFuncVIIIII(env, "go_step", stepCallback)
-	util.ExportFuncVIII(env, "go_final", finalCallback)
-	util.ExportFuncVII(env, "go_value", valueCallback)
+	util.ExportFuncVIIII(env, "go_value", valueCallback)
 	util.ExportFuncVIIII(env, "go_inverse", inverseCallback)
 	util.ExportFuncVIIII(env, "go_collation_needed", collationCallback)
 	util.ExportFuncIIIIII(env, "go_compare", compareCallback)

sqlite3/func.c

@@ -11,9 +11,8 @@ int go_compare(go_handle, int, const void *, int, const void *);
 void go_func(sqlite3_context *, go_handle, int, sqlite3_value **);
 
 void go_step(sqlite3_context *, go_handle *, go_handle, int, sqlite3_value **);
-void go_final(sqlite3_context *, go_handle, go_handle);
-void go_value(sqlite3_context *, go_handle);
-void go_inverse(sqlite3_context *, go_handle *, int, sqlite3_value **);
+void go_value(sqlite3_context *, go_handle *, go_handle, bool);
+void go_inverse(sqlite3_context *, go_handle, int, sqlite3_value **);
 
 void go_func_wrapper(sqlite3_context *ctx, int nArg, sqlite3_value **pArg) {
   go_func(ctx, sqlite3_user_data(ctx), nArg, pArg);
@@ -28,22 +27,26 @@ void go_step_wrapper(sqlite3_context *ctx, int nArg, sqlite3_value **pArg) {
   go_step(ctx, agg, data, nArg, pArg);
 }
 
+void go_value_wrapper(sqlite3_context *ctx) {
+  go_handle *agg = sqlite3_aggregate_context(ctx, 4);
+  go_handle data = NULL;
+  if (agg == NULL || *agg == NULL) {
+    data = sqlite3_user_data(ctx);
+  }
+  go_value(ctx, agg, data, /*final=*/false);
+}
+
 void go_final_wrapper(sqlite3_context *ctx) {
   go_handle *agg = sqlite3_aggregate_context(ctx, 0);
   go_handle data = NULL;
   if (agg == NULL || *agg == NULL) {
     data = sqlite3_user_data(ctx);
   }
-  go_final(ctx, agg, data);
-}
-
-void go_value_wrapper(sqlite3_context *ctx) {
-  go_handle *agg = sqlite3_aggregate_context(ctx, 4);
-  go_value(ctx, *agg);
+  go_value(ctx, agg, data, /*final=*/true);
 }
 
 void go_inverse_wrapper(sqlite3_context *ctx, int nArg, sqlite3_value **pArg) {
-  go_handle *agg = sqlite3_aggregate_context(ctx, 4);
+  go_handle *agg = sqlite3_aggregate_context(ctx, 0);
   go_inverse(ctx, *agg, nArg, pArg);
 }
 

sqlite3/hooks.c

@@ -19,6 +19,10 @@ void go_log(void *, int, const char *);
 unsigned int go_autovacuum_pages(void *, const char *, unsigned int,
                                  unsigned int, unsigned int);
 
+void sqlite3_log_go(int iErrCode, const char *zMsg) {
+  sqlite3_log(iErrCode, "%s", zMsg);
+}
+
 void sqlite3_progress_handler_go(sqlite3 *db, int n) {
   sqlite3_progress_handler(db, n, go_progress_handler, /*arg=*/NULL);
 }