js/shoelace
1
0
Fork 0
mirror of https://github.com/shoelace-style/shoelace.git synced 2026-01-12 02:59:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

resolve feedback

Browse Source
This commit is contained in:
Cory LaViska
2023-08-21 10:56:25 -04:00
parent c6d69fdbd6
commit 3217ce9f76
2 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/components/menu-item/menu-item.component.ts
View File

@@ -1,9 +1,8 @@
import '../icon/icon.js';
import { classMap } from 'lit/directives/class-map.js';
import { customElement, property, query } from 'lit/decorators.js';
import { getTextContent, HasSlotController } from '../../internal/slot.js';
import { html } from 'lit';
import { LocalizeController } from '../../utilities/localize.js';
import { property, query } from 'lit/decorators.js';
import { SubmenuController } from './submenu-controller.js';
import { watch } from '../../internal/watch.js';
import ShoelaceElement from '../../internal/shoelace-element.js';
@@ -35,7 +34,6 @@ import type { CSSResultGroup } from 'lit';
*
* @cssproperty [--submenu-offset=-2px] - The distance submenus shift to overlap the parent menu.
*/
@customElement('sl-menu-item')
export default class SlMenuItem extends ShoelaceElement {
static styles: CSSResultGroup = styles;
static dependencies = {
@@ -64,10 +62,6 @@ export default class SlMenuItem extends ShoelaceElement {
private readonly hasSlotController = new HasSlotController(this, 'submenu');
private submenuController: SubmenuController = new SubmenuController(this, this.hasSlotController, this.localize);
constructor() {
super();
}
connectedCallback() {
super.connectedCallback();
this.addEventListener('click', this.handleHostClick);

5
src/components/menu/menu.component.ts
View File

@@ -1,7 +1,7 @@
import { customElement, query } from 'lit/decorators.js';
import { html } from 'lit';
import { query } from 'lit/decorators.js';
import ShoelaceElement from '../../internal/shoelace-element.js';
import SlMenuItem from '../menu-item/menu-item.js';
import SlMenuItem from '../menu-item/menu-item.component.js';
import styles from './menu.styles.js';
import type { CSSResultGroup } from 'lit';
export interface MenuSelectEventDetail {
@@ -18,7 +18,6 @@ export interface MenuSelectEventDetail {
*
* @event {{ item: SlMenuItem }} sl-select - Emitted when a menu item is selected.
*/
@customElement('sl-menu')
export default class SlMenu extends ShoelaceElement {
static styles: CSSResultGroup = styles;