js/shoelace
1
0
Fork 0
mirror of https://github.com/shoelace-style/shoelace.git synced 2026-01-12 02:59:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix possibly leaking eventlisteners (#2257)

Browse Source
This commit is contained in:
Enrico Gruner
2024-11-04 21:51:19 +01:00
committed by GitHub
parent b70fa163e1
commit 569acdb7c9
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/dialog/dialog.component.ts
View File

@@ -114,7 +114,7 @@ export default class SlDialog extends ShoelaceElement {
super.disconnectedCallback();
this.modal.deactivate();
unlockBodyScrolling(this);
this.closeWatcher?.destroy();
this.removeOpenListeners();
}
private requestClose(source: 'close-button' | 'keyboard' | 'overlay') {

2
src/components/drawer/drawer.component.ts
View File

@@ -131,7 +131,7 @@ export default class SlDrawer extends ShoelaceElement {
disconnectedCallback() {
super.disconnectedCallback();
unlockBodyScrolling(this);
this.closeWatcher?.destroy();
this.removeOpenListeners();
}
private requestClose(source: 'close-button' | 'keyboard' | 'overlay') {