improve range/tooltip perf; fixes #2064 (#2237)

This commit is contained in:
Cory LaViska
2024-10-28 13:39:12 -04:00
committed by GitHub
parent aca0f3d64a
commit 80c3d8784b
2 changed files with 2 additions and 1 deletions

View File

@@ -17,6 +17,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti
- Added support for <kbd>Enter</kbd> to `<sl-split-panel>` to align with ARIA APG's [window splitter pattern](https://www.w3.org/WAI/ARIA/apg/patterns/windowsplitter/) [#2234]
- Fixed a bug in `<sl-carousel>` that caused the navigation icons to be reversed
- Fixed a bug in `<sl-select>` that prevented label changes in `<sl-option>` from updating the controller [#1971]
- Improved performance of `<sl-range>` by skipping positioning logic when tooltip isn't shown [#2064]
## 2.18.0

View File

@@ -215,7 +215,7 @@ export default class SlRange extends ShoelaceElement implements ShoelaceFormCont
this.syncProgress(percent);
if (this.tooltip !== 'none') {
if (this.tooltip !== 'none' && this.hasTooltip) {
// Ensure updates are drawn before we sync the tooltip
this.updateComplete.then(() => this.syncTooltip(percent));
}