js/shoelace
1
0
Fork 0
mirror of https://github.com/shoelace-style/shoelace.git synced 2026-01-12 02:59:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only trigger defaultslotchange of select after initialization (#2318)

Browse Source
This commit is contained in:
Susanne Kirchner
2025-01-02 15:59:18 +01:00
committed by GitHub
parent b5e82d676a
commit 81e94f2624
1 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/components/option/option.component.ts
View File

@@ -34,6 +34,8 @@ export default class SlOption extends ShoelaceElement {
// @ts-expect-error - Controller is currently unused
private readonly localize = new LocalizeController(this);
private isInitialized = false;
@query('.option__label') defaultSlot: HTMLSlotElement;
@state() current = false; // the user has keyed into the option, but hasn't selected it yet (shows a highlight)
@@ -57,13 +59,17 @@ export default class SlOption extends ShoelaceElement {
}
private handleDefaultSlotChange() {
// When the label changes, tell the controller to update
customElements.whenDefined('sl-select').then(() => {
const controller = this.closest('sl-select');
if (controller) {
controller.handleDefaultSlotChange();
}
});
if (this.isInitialized) {
// When the label changes, tell the controller to update
customElements.whenDefined('sl-select').then(() => {
const controller = this.closest('sl-select');
if (controller) {
controller.handleDefaultSlotChange();
}
});
} else {
this.isInitialized = true;
}
}
private handleMouseEnter() {