mirror of
https://github.com/shoelace-style/shoelace.git
synced 2026-01-12 02:59:13 +00:00
don't block escape; fixes #1607
This commit is contained in:
@@ -15,6 +15,7 @@ New versions of Shoelace are released as-needed and generally occur when a criti
|
||||
## Next
|
||||
|
||||
- Added the Croatian translation [#1656]
|
||||
- Fixed a bug that caused the [[Escape]] key to stop propagating when tooltips are disabled [#1607]
|
||||
|
||||
## 2.10.0
|
||||
|
||||
|
||||
@@ -145,7 +145,7 @@ export default class SlTooltip extends ShoelaceElement {
|
||||
|
||||
private handleKeyDown = (event: KeyboardEvent) => {
|
||||
// Pressing escape when the target element has focus should dismiss the tooltip
|
||||
if (this.open && event.key === 'Escape') {
|
||||
if (this.open && !this.disabled && event.key === 'Escape') {
|
||||
event.stopPropagation();
|
||||
this.hide();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user