js/shoelace
1
0
Fork 0
mirror of https://github.com/shoelace-style/shoelace.git synced 2026-01-12 02:59:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

sl-tab-group throws error if unmounted too fast (#2218)

Browse Source 
* Add check for undefined element on disconnect

* Fix prettier error
This commit is contained in:
Susanne Kirchner
2024-10-16 16:53:11 +02:00
committed by GitHub
parent 2c66c859d6
commit b14498822b
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/components/tab-group/tab-group.component.ts
View File

@@ -128,7 +128,10 @@ export default class SlTabGroup extends ShoelaceElement {
disconnectedCallback() {
super.disconnectedCallback();
this.mutationObserver?.disconnect();
this.resizeObserver?.unobserve(this.nav);
if (this.nav) {
this.resizeObserver?.unobserve(this.nav);
}
}
private getAllTabs() {

7
src/components/tab-group/tab-group.test.ts
View File

@@ -84,6 +84,13 @@ describe('<sl-tab-group>', () => {
expect(tabGroup).to.be.visible;
});
it('should not throw error when unmounted too fast', async () => {
const el = await fixture(html` <div></div> `);
el.innerHTML = '<sl-tab-group></sl-tab-group>';
el.innerHTML = '';
});
it('is accessible', async () => {
const tabGroup = await fixture<SlTabGroup>(html`
<sl-tab-group>