js/shoelace
1
0
Fork 0
mirror of https://github.com/shoelace-style/shoelace.git synced 2026-01-12 02:59:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Move keydown handler for sl-drawer back to base div (#1459)"

Browse Source 
This reverts commit 1e243e4257.
This commit is contained in:
Cory LaViska
2023-07-18 12:12:43 -04:00
parent 8267968b76
commit f954233bda
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/components/drawer/drawer.ts
View File

@@ -120,10 +120,6 @@ export default class SlDrawer extends ShoelaceElement {
lockBodyScrolling(this);
}
}
// If there is an autofocus element, let it take focuse normally, otherwise focus the panel.
if (!this.querySelector('[autofocus]')) {
this.panel.focus({ preventScroll: true });
}
}
disconnectedCallback() {
@@ -147,14 +143,14 @@ export default class SlDrawer extends ShoelaceElement {
}
private addOpenListeners() {
this.drawer.addEventListener('keydown', this.handleKeyDown);
document.addEventListener('keydown', this.handleDocumentKeyDown);
}
private removeOpenListeners() {
this.drawer.removeEventListener('keydown', this.handleKeyDown);
document.removeEventListener('keydown', this.handleDocumentKeyDown);
}
private handleKeyDown = (event: KeyboardEvent) => {
private handleDocumentKeyDown = (event: KeyboardEvent) => {
if (this.open && !this.contained && event.key === 'Escape') {
event.stopPropagation();
this.requestClose('keyboard');
@@ -311,7 +307,6 @@ export default class SlDrawer extends ShoelaceElement {
'drawer--rtl': this.localize.dir() === 'rtl',
'drawer--has-footer': this.hasSlotController.test('footer')
})}
@keydown=${this.handleKeyDown}
>
<div part="overlay" class="drawer__overlay" @click=${() => this.requestClose('overlay')} tabindex="-1"></div>