Merge pull request #210 from shoelace-style/konnorrogers/fix-rating-with-precision

Fix `<wa-rating>` when using precision
This commit is contained in:
Cory LaViska
2024-11-14 10:29:50 -05:00
committed by GitHub
2 changed files with 2 additions and 1 deletions

View File

@@ -16,6 +16,7 @@ During the alpha period, things might break! We take breaking changes very serio
- Added support for <kbd>Enter</kbd> to `<sl-split-panel>` to align with ARIA APG's [window splitter pattern](https://www.w3.org/WAI/ARIA/apg/patterns/windowsplitter/)
- Added more resilient support for lazy loaded options in `<wa-select>`
- Fixed a bug in `<wa-rating>` when using `precision`
- Fixed a bug in `<wa-relative-time>` where the title attribute would show with redundant info
- Fixed a bug in `<wa-tooltip>` that caused a memory leak in disconnected elements
- Fixed a bug in `<wa-select>` that prevented label changes in `<wa-option>` from updating the controller

View File

@@ -272,7 +272,7 @@ export default class WaRating extends WebAwesomeElement {
: `inset(0 0 0 ${(displayValue - index) * 100}%)`
})}
>
${this.getSymbol(index + 1)}
${unsafeHTML(this.getSymbol(index + 1))}
</div>
<div
class="rating__partial--filled"