Use PropertyKey instead of string where appropriate

This commit is contained in:
Matt Pharoah
2023-02-09 13:06:17 -05:00
parent b8584c0581
commit 610a06bcb9
24 changed files with 29 additions and 29 deletions

View File

@@ -1,4 +1,4 @@
type SlAfterCollapseEvent = CustomEvent<Record<string, never>>;
type SlAfterCollapseEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlAfterExpandEvent = CustomEvent<Record<string, never>>;
type SlAfterExpandEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlAfterHideEvent = CustomEvent<Record<string, never>>;
type SlAfterHideEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlAfterShowEvent = CustomEvent<Record<string, never>>;
type SlAfterShowEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlBlurEvent = CustomEvent<Record<string, never>>;
type SlBlurEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlCancelEvent = CustomEvent<Record<string, never>>;
type SlCancelEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlChangeEvent = CustomEvent<Record<string, never>>;
type SlChangeEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlClearEvent = CustomEvent<Record<string, never>>;
type SlClearEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlCloseEvent = CustomEvent<Record<string, never>>;
type SlCloseEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlCollapseEvent = CustomEvent<Record<string, never>>;
type SlCollapseEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlExpandEvent = CustomEvent<Record<string, never>>;
type SlExpandEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlFinishEvent = CustomEvent<Record<string, never>>;
type SlFinishEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlFocusEvent = CustomEvent<Record<string, never>>;
type SlFocusEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlHideEvent = CustomEvent<Record<string, never>>;
type SlHideEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlInitialFocusEvent = CustomEvent<Record<string, never>>;
type SlInitialFocusEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlInputEvent = CustomEvent<Record<string, never>>;
type SlInputEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlLazyChangeEvent = CustomEvent<Record<string, never>>;
type SlLazyChangeEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlLazyLoadEvent = CustomEvent<Record<string, never>>;
type SlLazyLoadEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlLoadEvent = CustomEvent<Record<string, never>>;
type SlLoadEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlRemoveEvent = CustomEvent<Record<string, never>>;
type SlRemoveEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlRepositionEvent = CustomEvent<Record<string, never>>;
type SlRepositionEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlShowEvent = CustomEvent<Record<string, never>>;
type SlShowEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -1,4 +1,4 @@
type SlStartEvent = CustomEvent<Record<string, never>>;
type SlStartEvent = CustomEvent<Record<PropertyKey, never>>;
declare global {
interface GlobalEventHandlersEventMap {

View File

@@ -2,8 +2,8 @@ import { LitElement } from 'lit';
import { property } from 'lit/decorators.js';
type EventTypeRequiresDetail<T> = T extends keyof GlobalEventHandlersEventMap
? GlobalEventHandlersEventMap[T] extends CustomEvent<Record<string, unknown>>
? GlobalEventHandlersEventMap[T] extends CustomEvent<Record<string, never>>
? GlobalEventHandlersEventMap[T] extends CustomEvent<Record<PropertyKey, unknown>>
? GlobalEventHandlersEventMap[T] extends CustomEvent<Record<PropertyKey, never>>
? never
: Partial<GlobalEventHandlersEventMap[T]['detail']> extends GlobalEventHandlersEventMap[T]['detail']
? never
@@ -12,8 +12,8 @@ type EventTypeRequiresDetail<T> = T extends keyof GlobalEventHandlersEventMap
: never;
type EventTypeDoesNotRequireDetail<T> = T extends keyof GlobalEventHandlersEventMap
? GlobalEventHandlersEventMap[T] extends CustomEvent<Record<string, unknown>>
? GlobalEventHandlersEventMap[T] extends CustomEvent<Record<string, never>>
? GlobalEventHandlersEventMap[T] extends CustomEvent<Record<PropertyKey, unknown>>
? GlobalEventHandlersEventMap[T] extends CustomEvent<Record<PropertyKey, never>>
? T
: Partial<GlobalEventHandlersEventMap[T]['detail']> extends GlobalEventHandlersEventMap[T]['detail']
? T
@@ -31,8 +31,8 @@ type EventTypesWithoutRequiredDetail = {
type WithRequired<T, K extends keyof T> = T & { [P in K]-?: T[P] };
type SlEventInit<T> = T extends keyof GlobalEventHandlersEventMap
? GlobalEventHandlersEventMap[T] extends CustomEvent<Record<string, unknown>>
? GlobalEventHandlersEventMap[T] extends CustomEvent<Record<string, never>>
? GlobalEventHandlersEventMap[T] extends CustomEvent<Record<PropertyKey, unknown>>
? GlobalEventHandlersEventMap[T] extends CustomEvent<Record<PropertyKey, never>>
? CustomEventInit<GlobalEventHandlersEventMap[T]['detail']>
: Partial<GlobalEventHandlersEventMap[T]['detail']> extends GlobalEventHandlersEventMap[T]['detail']
? CustomEventInit<GlobalEventHandlersEventMap[T]['detail']>