remove navigation button

This commit is contained in:
konnorrogers
2023-10-02 11:58:56 -04:00
parent e95bfab77b
commit 74d5b4c3f4
3 changed files with 3 additions and 48 deletions

View File

@@ -26,7 +26,6 @@ import type { CSSResultGroup, PropertyValueMap } from 'lit';
* @slot main-footer - Footer to display inline below the main content
* @slot aside - Content to be shown on the right side of the page. Generally this may be table of contents, ads, etc. This is sticky.
* @slot skip-links - If you would like to override the `Skip to main` button and add additional "Skip to X", they can be inserted here.
* @slot nav-button - For overriding the default `<wa-icon-button>` displayed as the fallback on mobile viewports
* @slot footer - The content to display in the footer. This is always displayed underneath the viewport so will always make the page "scrollable".
*
* @csspart base - The component's base wrapper.
@@ -72,21 +71,11 @@ export default class WaLayout extends WebAwesomeElement {
*/
@property({ attribute: 'view', reflect: true }) view: 'mobile' | 'desktop' = 'mobile';
/**
* Hides the default navigation button fallback allowing you to create your own mobile navigation experience.
*/
@property({ attribute: 'hide-nav-button', reflect: true, type: Boolean }) hideNavButton = false;
/**
* At what "px" to hide the "menu" slot and collapse into a hamburger button
*/
@property({ attribute: 'mobile-breakpoint' }) mobileBreakpoint = 768;
/**
* Where to place the navigation when in the mobile viewport.
*/
@property({ attribute: 'navigation-placement', reflect: true }) navigationPlacement: 'start' | 'end' = 'start';
layoutResizeObserver = new ResizeObserver(entries => {
for (const entry of entries) {
if (entry.contentBoxSize) {
@@ -182,15 +171,6 @@ export default class WaLayout extends WebAwesomeElement {
}
}
private renderNavButton() {
return html`
<slot name="nav-button">
<wa-icon-button name="list" variant="text" size="large" @click=${this.showNavigation} part="nav-button">
</wa-icon-button>
</slot>
`;
}
render() {
return html`
<wa-visually-hidden class="skip-links" part="skip-links">
@@ -212,11 +192,7 @@ export default class WaLayout extends WebAwesomeElement {
</div>
<div class="header" part="header">
${when(this.navigationPlacement === 'start', () => this.renderNavButton())}
<slot name="header"></slot>
${when(this.navigationPlacement === 'end', () => this.renderNavButton())}
</div>
<div class="sub-header" part="sub-header">

View File

@@ -79,21 +79,6 @@ export default css`
[part~='header'] {
top: var(--banner-height);
display: grid;
grid-template-columns: minmax(0, auto) minmax(0, 1fr);
align-items: center;
}
:host([navigation-placement='end']) [part~='header'] {
grid-template-columns: minmax(0, 1fr) minmax(0, auto);
}
:host([hide-nav-button]) [part~='nav-button'] {
display: none;
}
:host([hide-nav-button]) [part~='header'] {
grid-template-columns: minmax(0, 1fr);
}
[part~='sub-header'] {
@@ -161,8 +146,4 @@ export default css`
grid-template-columns: minmax(0, 1fr);
grid-template-rows: minmax(0, auto) minmax(0, 1fr) minmax(0, auto);
}
[part~='nav-button'] {
font-size: 1.5rem;
}
`;

View File

@@ -9,11 +9,6 @@ export default css`
--gap: 6px;
}
p {
margin: 0;
margin-bottom: var(--wa-space-xs);
}
.base {
color: var(--wa-color-text-normal);
height: 100%;
@@ -23,6 +18,9 @@ export default css`
font-weight: var(--wa-font-weight-heading);
color: var(--wa-color-neutral-text-on-surface);
padding-inline-start: var(--wa-space-xs);
margin: 0;
/** This is a cheap way to have labels have a bottom margin withot needing slot test controllers. */
line-height: calc(1em + 32px);
}
.nav-items {