js/webawesome
1
0
Fork 0
mirror of https://github.com/shoelace-style/webawesome.git synced 2026-01-12 04:09:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid null dereference when removing event listeners in Dropdown (#958)

Browse Source
This commit is contained in:
bolte-17
2022-10-27 09:28:35 -04:00
committed by GitHub
parent a8de02bd53
commit 8893045bf1
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/components/dropdown/dropdown.ts
View File

@@ -346,8 +346,10 @@ export default class SlDropdown extends ShoelaceElement {
}
removeOpenListeners() {
this.panel.removeEventListener('sl-activate', this.handleMenuItemActivate);
this.panel.removeEventListener('sl-select', this.handlePanelSelect);
if (this.panel) {
this.panel.removeEventListener('sl-activate', this.handleMenuItemActivate);
this.panel.removeEventListener('sl-select', this.handlePanelSelect);
}
document.removeEventListener('keydown', this.handleDocumentKeyDown);
document.removeEventListener('mousedown', this.handleDocumentMouseDown);
}