js/webawesome
1
0
Fork 0
mirror of https://github.com/shoelace-style/webawesome.git synced 2026-01-12 04:09:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'fix/tabgroup-mutation-observer' of https://github.com/lamplightdev/shoelace into fix/tabgroup-mutation-observer

Browse Source 
* 'fix/tabgroup-mutation-observer' of https://github.com/lamplightdev/shoelace:
  Fix typo in aria attribute
  Fixes #148 - prevents recursive calls to observer
This commit is contained in:
Chris Haynes
2020-08-01 22:43:17 +01:00
parent 8f0c1eb339 d09c4f06a7
commit 92fdc551d8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/tab-group/tab-group.tsx
View File

@@ -62,7 +62,7 @@ export class TabGroup {
this.mutationObserver = new MutationObserver(mutations => {
if (
mutations.some(mutation => {
return !['arial-labeledby', 'aria-controls'].includes(mutation.attributeName);
return !['aria-labeledby', 'aria-controls'].includes(mutation.attributeName);
})
) {
setTimeout(() => this.setAriaLabels());
@@ -141,7 +141,7 @@ export class TabGroup {
const panel = panels.find(el => el.name === tab.panel);
if (panel) {
tab.setAttribute('aria-controls', panel.getAttribute('id'));
panel.setAttribute('arial-labeledby', tab.getAttribute('id'));
panel.setAttribute('aria-labeledby', tab.getAttribute('id'));
}
});
}