make event cancelable (#1434)

This commit is contained in:
Cory LaViska
2025-09-11 11:55:35 -04:00
committed by GitHub
parent 6dce88429a
commit 986e52f977
2 changed files with 6 additions and 2 deletions

View File

@@ -8,6 +8,10 @@ Web Awesome follows [Semantic Versioning](https://semver.org/). Breaking changes
Components with the <wa-badge variant="warning">Experimental</wa-badge> badge should not be used in production. They are made available as release candidates for development and testing purposes. As such, changes to experimental components will not be subject to semantic versioning.
## Next
- Fixed a bug in `<wa-dropdown>` that closed the dropdown event when preventing `wa-select` [issue:1432]
## 3.0.0-beta.5
### Bug Fixes and Improvements {data-no-outline}
@@ -444,4 +448,4 @@ Many of these changes and improvements were the direct result of feedback from u
</details>
Did we miss something? [Let us know!](https://github.com/shoelace-style/webawesome/discussions)
Did we miss something? [Let us know!](https://github.com/shoelace-style/webawesome/discussions)

View File

@@ -2,7 +2,7 @@ export class WaSelectEvent extends Event {
readonly detail;
constructor(detail: WaSelectEventDetail) {
super('wa-select', { bubbles: true, cancelable: false, composed: true });
super('wa-select', { bubbles: true, cancelable: true, composed: true });
this.detail = detail;
}
}