js/webawesome
1
0
Fork 0
mirror of https://github.com/shoelace-style/webawesome.git synced 2026-01-12 12:09:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

temporarily disable a11y bug

Browse Source
This commit is contained in:
Cory LaViska
2022-12-20 13:37:30 -05:00
parent e2a65c28f4
commit b07238d536
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/components/menu-item/menu-item.test.ts
View File

@@ -5,9 +5,11 @@ import type SlMenuItem from './menu-item';
describe('<sl-menu-item>', () => {
it('passes accessibility test', async () => {
const el = await fixture<SlMenuItem>(html`
<sl-select>
<sl-menu-item>Test</sl-menu-item>
</sl-select>
<sl-menu>
<sl-menu-item>Item 1</sl-menu-item>
<sl-menu-item>Item 2</sl-menu-item>
<sl-menu-item>Item 3</sl-menu-item>
</sl-menu>
`);
await expect(el).to.be.accessible();
});
@@ -15,8 +17,6 @@ describe('<sl-menu-item>', () => {
it('default properties', async () => {
const el = await fixture<SlMenuItem>(html` <sl-menu-item>Test</sl-menu-item> `);
expect(el.checked).to.be.false;
expect(el.getAttribute('aria-checked')).to.equal('false');
expect(el.value).to.equal('');
expect(el.disabled).to.be.false;
expect(el.getAttribute('aria-disabled')).to.equal('false');
@@ -25,9 +25,6 @@ describe('<sl-menu-item>', () => {
it('changes aria attributes', async () => {
const el = await fixture<SlMenuItem>(html` <sl-menu-item>Test</sl-menu-item> `);
el.checked = true;
await aTimeout(100);
expect(el.getAttribute('aria-checked')).to.equal('true');
el.disabled = true;
await aTimeout(100);
expect(el.getAttribute('aria-disabled')).to.equal('true');

5
src/components/menu-item/menu-item.ts
View File

@@ -58,7 +58,10 @@ export default class SlMenuItem extends ShoelaceElement {
@watch('checked')
handleCheckedChange() {
this.setAttribute('aria-checked', this.checked ? 'true' : 'false');
//
// TODO - fix a11y bug
//
// this.setAttribute('aria-checked', this.checked ? 'true' : 'false');
}
@watch('disabled')