remove unused events

This commit is contained in:
Cory LaViska
2021-04-01 09:17:05 -04:00
parent 2e893bbaf2
commit b2599d5a9f
2 changed files with 1 additions and 27 deletions

View File

@@ -15,6 +15,7 @@ _During the beta period, these restrictions may be relaxed in the event of a mis
- Fixed incorrect event names for `sl-after-show` and `sl-after-hide` in `sl-details`
- Improved a11y for disabled buttons that are rendered as links
- Improved a11y for `sl-button-group`
- Removed `sl-show`, `sl-hide`, `sl-after-show`, `sl-after-hide` events from `sl-color-picker` (the color picker's visibility cannot be controlled programmatically so these shouldn't have been exposed; the dropdown events now bubble up so you can listen for those instead)
## 2.0.0-beta.36

View File

@@ -119,18 +119,6 @@ export default class SlColorPicker extends LitElement {
/** Emitted when the color picker's value changes. */
@event('sl-change') slChange: EventEmitter<void>;
/** Emitted when the color picker opens. Calling `event.preventDefault()` will prevent it from being opened. */
@event('sl-show') slShow: EventEmitter<void>;
/** Emitted after the color picker opens and all transitions are complete. */
@event('sl-after-show') slAfterShow: EventEmitter<void>;
/** Emitted when the color picker closes. Calling `event.preventDefault()` will prevent it from being closed. */
@event('sl-hide') slHide: EventEmitter<void>;
/** Emitted after the color picker closes and all transitions are complete. */
@event('sl-after-hide') slAfterHide: EventEmitter<void>;
connectedCallback() {
super.connectedCallback();
@@ -391,24 +379,11 @@ export default class SlColorPicker extends LitElement {
if (this.disabled) {
event.preventDefault();
} else {
this.slShow.emit();
}
}
handleDropdownAfterShow(event: CustomEvent) {
event.stopPropagation();
this.slAfterShow.emit();
}
handleDropdownHide(event: CustomEvent) {
event.stopPropagation();
this.slHide.emit();
}
handleDropdownAfterHide(event: CustomEvent) {
event.stopPropagation();
this.slAfterHide.emit();
this.showCopyFeedback = false;
}
@@ -804,8 +779,6 @@ export default class SlColorPicker extends LitElement {
.containing-element=${this}
?hoist=${this.hoist}
@sl-show=${this.handleDropdownShow}
@sl-after-show=${this.handleDropdownAfterShow}
@sl-hide=${this.handleDropdownHide}
@sl-after-hide=${this.handleDropdownAfterHide}
>
<button