js/webawesome
1
0
Fork 0
mirror of https://github.com/shoelace-style/webawesome.git synced 2026-01-12 12:09:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove bypass logic

Browse Source
This commit is contained in:
Cory LaViska
2021-05-03 11:32:38 -04:00
parent cf38478cd5
commit c8e94ea098
1 changed files with 9 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/components/color-picker/color-picker.ts
View File

@@ -40,7 +40,6 @@ export default class SlColorPicker extends LitElement {
@query('[part="preview"]') previewButton: HTMLButtonElement;
@query('.color-dropdown') dropdown: SlDropdown;
private bypassValueParse = false;
private lastValueEmitted: string;
@state() private inputValue = '';
@@ -551,12 +550,7 @@ export default class SlColorPicker extends LitElement {
this.inputValue = this.opacity ? currentColor.hexa : currentColor.hex;
}
// Setting this.value will trigger the watcher which parses the new value. We want to bypass that behavior because
// we've already parsed the color here and conversion/rounding can lead to values changing slightly. After the next
// update, the usual behavior is restored.
this.bypassValueParse = true;
this.value = this.inputValue;
this.updateComplete.then(() => (this.bypassValueParse = false));
}
@watch('format')
@@ -571,18 +565,16 @@ export default class SlColorPicker extends LitElement {
@watch('value')
handleValueChange(oldValue: string, newValue: string) {
if (!this.bypassValueParse) {
const newColor = this.parseColor(newValue);
const newColor = this.parseColor(newValue);
if (newColor) {
this.inputValue = this.value;
this.hue = newColor.hsla.h;
this.saturation = newColor.hsla.s;
this.lightness = newColor.hsla.l;
this.alpha = newColor.hsla.a * 100;
} else {
this.inputValue = oldValue;
}
if (newColor) {
this.inputValue = this.value;
this.hue = newColor.hsla.h;
this.saturation = newColor.hsla.s;
this.lightness = newColor.hsla.l;
this.alpha = newColor.hsla.a * 100;
} else {
this.inputValue = oldValue;
}
if (this.value !== this.lastValueEmitted) {