Merge pull request #277 from shoelace-style/konnorrogers/fix-dialog-show

Fix calling `.show()`
This commit is contained in:
Cory LaViska
2024-12-06 12:57:17 -05:00
committed by GitHub
2 changed files with 2 additions and 1 deletions

View File

@@ -21,6 +21,7 @@ During the alpha period, things might break! We take breaking changes very serio
- Added more resilient support for lazy loaded options in `<wa-select>`
- Added support for vertical button groups
- Added the `focus()` method to `<wa-radio-group>`
- Fixed a bug in `<wa-dialog>` when using `.show()`
- Fixed a bug in `<wa-rating>` when using `precision`
- Fixed a bug in `<wa-rating>` that allowed tabbing into the rating when readonly
- Fixed a bug in `<wa-relative-time>` where the title attribute would show with redundant info

View File

@@ -186,7 +186,7 @@ export default class WaDialog extends WebAwesomeElement {
// Open or close the dialog
if (this.open && !this.dialog.open) {
this.show();
} else if (this.dialog.open) {
} else if (!this.open && this.dialog.open) {
this.open = true;
this.requestClose(this.dialog);
}