mirror of
https://github.com/shoelace-style/webawesome.git
synced 2026-01-12 12:09:26 +00:00
Merge pull request #277 from shoelace-style/konnorrogers/fix-dialog-show
Fix calling `.show()`
This commit is contained in:
@@ -21,6 +21,7 @@ During the alpha period, things might break! We take breaking changes very serio
|
||||
- Added more resilient support for lazy loaded options in `<wa-select>`
|
||||
- Added support for vertical button groups
|
||||
- Added the `focus()` method to `<wa-radio-group>`
|
||||
- Fixed a bug in `<wa-dialog>` when using `.show()`
|
||||
- Fixed a bug in `<wa-rating>` when using `precision`
|
||||
- Fixed a bug in `<wa-rating>` that allowed tabbing into the rating when readonly
|
||||
- Fixed a bug in `<wa-relative-time>` where the title attribute would show with redundant info
|
||||
|
||||
@@ -186,7 +186,7 @@ export default class WaDialog extends WebAwesomeElement {
|
||||
// Open or close the dialog
|
||||
if (this.open && !this.dialog.open) {
|
||||
this.show();
|
||||
} else if (this.dialog.open) {
|
||||
} else if (!this.open && this.dialog.open) {
|
||||
this.open = true;
|
||||
this.requestClose(this.dialog);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user