Compare commits

...

6 Commits

Author SHA1 Message Date
konnorrogers
de1f34d5ce fix bug with custom tags 2025-11-17 18:43:07 -05:00
konnorrogers
0b1308fc90 Merge branch 'next' into konnorrogers/fix-select-issue 2025-11-17 18:37:16 -05:00
konnorrogers
342eff6256 prettier 2025-11-17 13:41:19 -05:00
konnorrogers
43296b55a4 update changelog 2025-11-17 13:41:09 -05:00
konnorrogers
d06e4e4ee3 fix comment 2025-11-17 13:37:43 -05:00
konnorrogers
e9acddd54c fix issue with select, and build script issue 2025-11-17 13:35:11 -05:00
3 changed files with 10 additions and 4 deletions

View File

@@ -16,6 +16,8 @@ Components with the <wa-badge variant="warning">Experimental</wa-badge> badge sh
- 🚨 BREAKING: Changed `appearance="filled outlined"` to `appearance="filled-outlined"` in `<wa-card>` [issue:1671]
- Fixed a bug in `<wa-slider>` that caused some touch devices to end up with the incorrect value [issue:1703]
- Fixed a bug in `<wa-card>` that prevented some slots from being detected correctly [discuss:1450]
- Fixed a bug in `<wa-select>` that caused options not to get cleared correctly. [pr:1782]
- Fixed a bug in `<wa-select>` that caused custom tags to not to get cleared correctly. [pr:1782]
- Improved performance of `<wa-icon>` so initial rendering occurs faster, especially with multiple icons on the page [issue:1729]
## 3.0.0
@@ -501,4 +503,4 @@ Many of these changes and improvements were the direct result of feedback from u
</details>
Did we miss something? [Let us know!](https://github.com/shoelace-style/webawesome/discussions)
Did we miss something? [Let us know!](https://github.com/shoelace-style/webawesome/discussions)

View File

@@ -437,8 +437,7 @@ export async function build(options = {}) {
await generateManifest();
}
// copy everything to unbundled before we generate bundles.
await copy(getCdnDir(), getDistDir(), { overwrite: true });
// Rebuild the bundle before rebuilding the site
await regenerateBundle();
// This needs to be outside of "isComponent" check because SSR needs to run on CSS files too.

View File

@@ -518,6 +518,8 @@ export default class WaSelect extends WebAwesomeFormAssociatedElement {
private handleClearClick(event: MouseEvent) {
event.stopPropagation();
this.hasInteracted = true;
this.valueHasChanged = true;
if (this.value !== null) {
this.setSelectedOptions([]);
@@ -603,12 +605,15 @@ export default class WaSelect extends WebAwesomeFormAssociatedElement {
if (this.disabled) return;
this.hasInteracted = true;
this.valueHasChanged = true;
// Use the directly provided option if available (from getTag method)
let option = directOption;
// If no direct option was provided, find the option from the event path
if (!option) {
const tagElement = (event.target as Element).closest('wa-tag[part~=tag]');
const tagElement = (event.target as Element).closest('wa-tag[with-remove]');
if (tagElement) {
// Find the index of this tag among all tags