Merge branch 'next' into scroller-fix

* fix svg fill; closes #1733

* remove fill

packages/webawesome/docs/assets/styles/search.css

@@ -5,7 +5,6 @@
   border-radius: var(--wa-border-radius-l);
   padding: 0;
   margin: 0 auto;
-  overflow: hidden;
 
   &::part(dialog) {
     margin-block-start: 10vh;

packages/webawesome/docs/docs/resources/changelog.md

@@ -13,17 +13,17 @@ Components with the <wa-badge variant="warning">Experimental</wa-badge> badge sh
 
 ## Next
 
-- 🚨 BREAKING: Changed `appearance="filled outlined"` to `appearance="filled-outlined"` in `<wa-card>` [issue:1671]
 - Fixed a bug in `<wa-slider>` that caused some touch devices to end up with the incorrect value [issue:1703]
 - Fixed a bug in `<wa-card>` that prevented some slots from being detected correctly [discuss:1450]
+- Fixed a z-index bug in `<wa-scroller>` styles [issue:1724]
+- Fixed a bug in `<wa-icon>` that caused some icon libraries to render with the incorrect SVG fill [issue:1733]
+- Fixed a bug in `<wa-tree-item>` that caused the spinner to not show when lazy loading [issue:1678]
 - Fixed a bug in `<wa-dropdown>` that caused the browser to hang when cancelling the `wa-hide` event [issue:1483]
-- Fixed a bug in `<wa-tab-group>` that ensures the active indicator always shows [issue:1206]
 - Improved performance of `<wa-icon>` so initial rendering occurs faster, especially with multiple icons on the page [issue:1729]
 
 ## 3.0.0
 
 - 🚨 BREAKING: Changed `appearance="filled outlined"` to `appearance="filled-outlined"` in the following elements [issue:1127]
-  - `<wa-badge>`
   - `<wa-button>`
   - `<wa-callout>`
   - `<wa-card>`

packages/webawesome/src/components/icon/icon.css

@@ -25,7 +25,6 @@
 
 svg {
   height: 1em;
-  fill: currentColor;
   overflow: visible;
 
   /* Duotone colors with path-specific opacity fallback */

packages/webawesome/src/components/icon/icon.ts

@@ -249,7 +249,7 @@ export default class WaIcon extends WebAwesomeElement {
       return this.svg;
     }
 
-    return html`<svg part="svg" fill="currentColor" width="16" height="16"></svg>`;
+    return html`<svg part="svg" width="16" height="16"></svg>`;
   }
 }
 

packages/webawesome/src/components/scroller/scroller.css

@@ -53,6 +53,19 @@
   overflow-y: auto;
 }
 
+#start-shadow,
+#end-shadow {
+  z-index: 2;
+}
+
+#start-shadow {
+  opacity: var(--start-shadow-opacity);
+}
+
+#end-shadow {
+  opacity: var(--end-shadow-opacity);
+}
+
 /* Horizontal shadows */
 :host([orientation='horizontal']) {
   #start-shadow,
@@ -64,14 +77,6 @@
     pointer-events: none;
   }
 
-  #start-shadow {
-    opacity: var(--start-shadow-opacity);
-  }
-
-  #end-shadow {
-    opacity: var(--end-shadow-opacity);
-  }
-
   #start-shadow {
     &:dir(ltr) {
       left: 0;
@@ -102,21 +107,12 @@
   #start-shadow,
   #end-shadow {
     position: absolute;
-    z-index: 2;
     right: 0;
     left: 0;
     height: var(--shadow-size);
     pointer-events: none;
   }
 
-  #start-shadow {
-    opacity: var(--start-shadow-opacity);
-  }
-
-  #end-shadow {
-    opacity: var(--end-shadow-opacity);
-  }
-
   #start-shadow {
     top: 0;
     background: linear-gradient(to bottom, var(--shadow-color), transparent 100%);

packages/webawesome/src/components/tab-group/tab-group.css

@@ -3,9 +3,6 @@
   --track-color: var(--wa-color-neutral-fill-normal);
   --track-width: 0.125rem;
 
-  /* Private */
-  --safe-track-width: max(0.5px, round(var(--track-width), 0.5px));
-
   display: block;
 }
 
@@ -80,12 +77,12 @@
   flex: 1 1 auto;
   position: relative;
   flex-direction: row;
-  border-bottom: solid var(--safe-track-width) var(--track-color);
+  border-bottom: solid var(--track-width) var(--track-color);
 }
 
 .tab-group-top .indicator {
-  bottom: calc(-1 * var(--safe-track-width));
-  border-bottom: solid var(--safe-track-width) var(--indicator-color);
+  bottom: calc(-1 * var(--track-width));
+  border-bottom: solid var(--track-width) var(--indicator-color);
 }
 
 .tab-group-top .body {
@@ -93,8 +90,8 @@
 }
 
 .tab-group-top ::slotted(wa-tab[active]) {
-  border-block-end: solid var(--safe-track-width) var(--indicator-color);
-  margin-block-end: calc(-1 * var(--safe-track-width));
+  border-block-end: solid var(--track-width) var(--indicator-color);
+  margin-block-end: calc(-1 * var(--track-width));
 }
 
 .tab-group-top ::slotted(wa-tab-panel) {
@@ -131,12 +128,12 @@
   flex: 1 1 auto;
   position: relative;
   flex-direction: row;
-  border-top: solid var(--safe-track-width) var(--track-color);
+  border-top: solid var(--track-width) var(--track-color);
 }
 
 .tab-group-bottom .indicator {
-  top: calc(-1 * var(--safe-track-width));
-  border-top: solid var(--safe-track-width) var(--indicator-color);
+  top: calc(-1 * var(--track-width));
+  border-top: solid var(--track-width) var(--indicator-color);
 }
 
 .tab-group-bottom .body {
@@ -144,8 +141,8 @@
 }
 
 .tab-group-bottom ::slotted(wa-tab[active]) {
-  border-block-start: solid var(--safe-track-width) var(--indicator-color);
-  margin-block-start: calc(-1 * var(--safe-track-width));
+  border-block-start: solid var(--track-width) var(--indicator-color);
+  margin-block-start: calc(-1 * var(--track-width));
 }
 
 .tab-group-bottom ::slotted(wa-tab-panel) {
@@ -167,12 +164,12 @@
 .tab-group-start .tabs {
   flex: 0 0 auto;
   flex-direction: column;
-  border-inline-end: solid var(--safe-track-width) var(--track-color);
+  border-inline-end: solid var(--track-width) var(--track-color);
 }
 
 .tab-group-start .indicator {
-  inset-inline-end: calc(-1 * var(--safe-track-width));
-  border-right: solid var(--safe-track-width) var(--indicator-color);
+  inset-inline-end: calc(-1 * var(--track-width));
+  border-right: solid var(--track-width) var(--indicator-color);
 }
 
 .tab-group-start .body {
@@ -181,8 +178,8 @@
 }
 
 .tab-group-start ::slotted(wa-tab[active]) {
-  border-inline-end: solid var(--safe-track-width) var(--indicator-color);
-  margin-inline-end: calc(-1 * var(--safe-track-width));
+  border-inline-end: solid var(--track-width) var(--indicator-color);
+  margin-inline-end: calc(-1 * var(--track-width));
 }
 
 .tab-group-start ::slotted(wa-tab-panel) {
@@ -204,12 +201,12 @@
 .tab-group-end .tabs {
   flex: 0 0 auto;
   flex-direction: column;
-  border-left: solid var(--safe-track-width) var(--track-color);
+  border-left: solid var(--track-width) var(--track-color);
 }
 
 .tab-group-end .indicator {
-  inset-inline-start: calc(-1 * var(--safe-track-width));
-  border-inline-start: solid var(--safe-track-width) var(--indicator-color);
+  inset-inline-start: calc(-1 * var(--track-width));
+  border-inline-start: solid var(--track-width) var(--indicator-color);
 }
 
 .tab-group-end .body {
@@ -218,8 +215,8 @@
 }
 
 .tab-group-end ::slotted(wa-tab[active]) {
-  border-inline-start: solid var(--safe-track-width) var(--indicator-color);
-  margin-inline-start: calc(-1 * var(--safe-track-width));
+  border-inline-start: solid var(--track-width) var(--indicator-color);
+  margin-inline-start: calc(-1 * var(--track-width));
 }
 
 .tab-group-end ::slotted(wa-tab-panel) {

packages/webawesome/src/components/tree-item/tree-item.css

@@ -73,12 +73,16 @@ slot:not([name])::slotted(wa-icon) {
   rotate: -90deg;
 }
 
-.tree-item-expanded slot[name='expand-icon'],
+.tree-item-expanded:not(.tree-item-loading) slot[name='expand-icon'],
 .tree-item:not(.tree-item-expanded) slot[name='collapse-icon'] {
   display: none;
 }
 
-.tree-item:not(.tree-item-has-expand-button) .expand-icon-slot {
+.tree-item:not(.tree-item-has-expand-button):not(.tree-item-loading) .expand-icon-slot {
+  display: none;
+}
+
+.tree-item-loading .expand-icon-slot wa-icon {
   display: none;
 }
 

packages/webawesome/src/components/tree-item/tree-item.ts

@@ -254,6 +254,7 @@ export default class WaTreeItem extends WebAwesomeElement {
           'tree-item-expanded': this.expanded,
           'tree-item-selected': this.selected,
           'tree-item-leaf': this.isLeaf,
+          'tree-item-loading': this.loading,
           'tree-item-has-expand-button': showExpandButton,
         })}"
       >
@@ -272,8 +273,10 @@ export default class WaTreeItem extends WebAwesomeElement {
               ${when(
                 this.loading,
                 () => html` <wa-spinner part="spinner" exportparts="base:spinner__base"></wa-spinner> `,
+                () => html`
+                  <wa-icon name=${isRtl ? 'chevron-left' : 'chevron-right'} library="system" variant="solid"></wa-icon>
+                `,
               )}
-              <wa-icon name=${isRtl ? 'chevron-left' : 'chevron-right'} library="system" variant="solid"></wa-icon>
             </slot>
             <slot class="expand-icon-slot" name="collapse-icon">
               <wa-icon name=${isRtl ? 'chevron-left' : 'chevron-right'} library="system" variant="solid"></wa-icon>