x/wiki
1
0
Fork 0
mirror of https://github.com/waynesutton/markdown-site.git synced 2026-01-12 04:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: move window.open before await to avoid popup blocker

Browse Source 
When content exceeds URL length limit, the async clipboard write
was blocking the window.open call. Browsers require window.open
to happen synchronously within user gesture handlers.
This commit is contained in:
Wayne Sutton
2025-12-20 23:29:32 -08:00
parent 953851f75d
commit 569244919d
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/components/CopyPageDropdown.tsx
View File

@@ -291,18 +291,19 @@ export default function CopyPageDropdown(props: CopyPageDropdownProps) {
// Generic handler for opening AI services
// All services receive the full markdown content directly
// IMPORTANT: window.open must happen BEFORE any await to avoid popup blockers
const handleOpenInAI = async (service: AIService) => {
const markdown = formatAsMarkdown(props);
const prompt = `Please analyze this article:\n\n${markdown}`;
// Build the target URL using the service's buildUrl function
if (!service.buildUrl) {
// Fallback: copy to clipboard and open base URL
// Fallback: open base URL FIRST (sync), then copy to clipboard
window.open(service.baseUrl, "_blank");
const success = await writeToClipboard(markdown);
if (success) {
setFeedback("url-too-long");
setFeedbackMessage("Copied! Paste in " + service.name);
window.open(service.baseUrl, "_blank");
} else {
setFeedback("error");
setFeedbackMessage("Failed to copy content");
@@ -313,13 +314,14 @@ export default function CopyPageDropdown(props: CopyPageDropdownProps) {
const targetUrl = service.buildUrl(prompt);
// Check URL length - if too long, copy to clipboard instead
// Check URL length - if too long, open base URL then copy to clipboard
if (isUrlTooLong(targetUrl)) {
// Open window FIRST (must be sync to avoid popup blocker)
window.open(service.baseUrl, "_blank");
const success = await writeToClipboard(markdown);
if (success) {
setFeedback("url-too-long");
setFeedbackMessage("Copied! Paste in " + service.name);
window.open(service.baseUrl, "_blank");
} else {
setFeedback("error");
setFeedbackMessage("Failed to copy content");