js/shoelace
1
0
Fork 0
mirror of https://github.com/shoelace-style/shoelace.git synced 2026-01-12 11:09:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace .map with .forEach when return value not used. See issue #740 (#1349)

Browse Source
This commit is contained in:
ErikOnBike
2023-05-24 16:34:42 +02:00
committed by konnorrogers
parent 7390ac37bf
commit fb899ad676
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/tab-group/tab-group.ts
View File

@@ -250,8 +250,8 @@ export default class SlTabGroup extends ShoelaceElement {
this.activeTab = tab;
// Sync active tab and panel
this.tabs.map(el => (el.active = el === this.activeTab));
this.panels.map(el => (el.active = el.name === this.activeTab?.panel));
this.tabs.forEach(el => (el.active = el === this.activeTab));
this.panels.forEach(el => (el.active = el.name === this.activeTab?.panel));
this.syncIndicator();
if (['top', 'bottom'].includes(this.placement)) {